Document labels, annotations and taints for JobSet

[Adarsh-verma-14]

Adding labels and annotation for JobSet in https://github.com/kubernetes/website/blob/main/content/en/docs/reference/labels-annotations-taints/_index.md

Fixes #47373

/language en

[Adarsh-verma-14]

Hi @sftim ,could you review on these changes if anythings need to change let me know .

[netlify[bot]]

✅ Pull request preview available for checking

Built without sensitive environment variables

Name	Link
🔨 Latest commit	fc4c0c7b47dc3cdd17cda89977fd68eed24dc3dd
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6703725bf718730008f25363
😎 Deploy Preview	https://deploy-preview-47383--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[kannon92]

cc @ahg-g @danielvegamyhre

[kannon92]

Thanks for working on this @kannon92, I added a couple comments

@Adarsh-verma-14 is the one who worked on this.

[sftim]

There is also one taint, so:

/retitle Document labels, annotations and taints for JobSet

[sftim]

/sig apps

[danielvegamyhre]

Thanks for working on this @kannon92, I added a couple comments

@Adarsh-verma-14 is the one who worked on this.

Woops, sorry about that @Adarsh-verma-14! Thanks for the contribution :)

[sftim]

Tide, is this OK to merge?

[Adarsh-verma-14]

Tide, is this OK to merge?

@sftim , I am not getting this, could you give more clarification ?

[sftim]

I am not getting this, could you give more clarification ?

I wanted to nudge Tide to recheck the PR status (it did).

[danielvegamyhre]

@sftim any blockers here? Scanning through it looks like comments have been addressed

[sftim]

This PR is ready for a review (any reviewer for English).

[danielvegamyhre]

This PR is ready for a review (any reviewer for English).

Thanks! Would you mind tagging a reviewer for this? I'm not sure who to add.

[sftim]

https://github.com/kubernetes/website/pull/47383#event-13795502968 shows the suggested reviewers. I'll take a look if I get time.

[sftim]

Waiting on author updates and then on tech LGTM.

[danielvegamyhre]

Thanks @Adarsh-verma-14, please tag me when this is ready for another review

[Adarsh-verma-14]

Thanks @Adarsh-verma-14, please tag me when this is ready for another review

Sure

[Adarsh-verma-14]

Hi @danielvegamyhre , I have updated changes as suggested now you can review on it .

[tengqm]

Sorry, I'm against this change because

• JobSet is not something we can get from vanilla Kubernetes. Yes. The mentioned labels or annotations all carry the k8s.io domain name, which is reserved. But this doesn't mean that they are "official".
• We could add notes (or warnings) to all these labels or annotations -- you can use them only when you deployed the jobset related manifests. They are not available by default on your cluster.
• Or, better yet, document these labels/annotations on a different page. The current page is already lengthy (>2400 lines). Without differentiating builtin labels/annotations from those from other projects, we will end up with a huge file pretty soon.

[sftim]

Thanks for the comment @tengqm, but JobSet is part of the Kubernetes project. I don't think we should force SIG Apps to reorganize a long page just to register their labels and annotations, even if that work is a good idea for the long term.

[danielvegamyhre]

/lgtm for JobSet

@sftim this is ready for SIG docs review

[danielvegamyhre]

@Adarsh-verma-14 can you address sftim@'s comments as soon as you can please? The JobSet blog post PR is blocked by this one, so we are hoping to get it merged as soon as possible :)

[Adarsh-verma-14]

@Adarsh-verma-14 can you address sftim@'s comments as soon as you can please? The JobSet blog post PR is blocked by this one, so we are hoping to get it merged as soon as possible :)

sure

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from sftim. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• content/en/docs/OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[Adarsh-verma-14]

Hi , I have updated these changes as suggested by @sftim . PTAL!!

[ahg-g]

Friendly ping @sftim

[danielvegamyhre]

@Adarsh-verma-14 can you address the last few comments here? Thanks!

[ahg-g]

Hello, anything blocking this one?

[sftim]

There's a lot of pending feedback. I noticed https://github.com/kubernetes/website/pull/47383#discussion_r1846197389

[ahg-g]

since @Adarsh-verma-14 is not responding, I will clone it and submit a PR tomorrow to close this