website icon indicating copy to clipboard operation
website copied to clipboard

Document two new feature gates around CEL cost enforcement

Open cici37 opened this issue 1 year ago β€’ 14 comments

related PR: https://github.com/kubernetes/kubernetes/pull/124675

Description

Issue

Closes: #

cici37 avatar Jul 31 '24 01:07 cici37

/sig api-machinery /assign @kubernetes/sig-docs-en-owners for approval. Thanks

cici37 avatar Jul 31 '24 01:07 cici37

Pull request preview available for checking

Built without sensitive environment variables

Name Link
Latest commit e0785af6c104e961bd2451ebcd6512aa2657be1a
Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66eb4373aabe7c0008775b03
Deploy Preview https://deploy-preview-47326--kubernetes-io-main-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jul 31 '24 01:07 netlify[bot]

Preview

kundan2707 avatar Jul 31 '24 02:07 kundan2707

changes looks good as per https://github.com/kubernetes/kubernetes/pull/124675

kundan2707 avatar Jul 31 '24 02:07 kundan2707

/lgtm

kundan2707 avatar Jul 31 '24 02:07 kundan2707

/hold

Should this PR target main or dev-1.31?

sftim avatar Jul 31 '24 08:07 sftim

@sftim it should be main because as it was planned to make default value true in 1.31.

kundan2707 avatar Jul 31 '24 08:07 kundan2707

The relevant discussion according to the tagged PR is here.

divya-mohan0209 avatar Jul 31 '24 08:07 divya-mohan0209

/approve

sftim avatar Jul 31 '24 09:07 sftim

/hold wait ... none of these two gates were effective in 1.30, right? I'm talking about the fact, not the plan.

tengqm avatar Jul 31 '24 09:07 tengqm

/lgtm cancel /approve cancel

Let's check

sftim avatar Jul 31 '24 09:07 sftim

@cici37 what's the first release where configuring these feature gates is / will be possible?

sftim avatar Jul 31 '24 09:07 sftim

@cici37 what's the first release where configuring these feature gates is / will be possible?

Those fg is a special feature gate used for fixing security concern and were cherry picked back to 1.30 as well.

cici37 avatar Sep 18 '24 21:09 cici37

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from sftim. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 18 '24 21:09 k8s-ci-robot

@cici37 PTAL at feedback so far

sftim avatar Oct 02 '24 13:10 sftim

Closing as stale.

@cici37 feel free to reopen if you'd like to.

/close

nate-double-u avatar Feb 22 '25 00:02 nate-double-u

@nate-double-u: Closed this PR.

In response to this:

Closing as stale.

@cici37 feel free to reopen if you'd like to.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Feb 22 '25 00:02 k8s-ci-robot