website icon indicating copy to clipboard operation
website copied to clipboard

Updating Windows node eviction signals docs

Open marosset opened this issue 1 year ago • 12 comments

Description

Issue

https://github.com/kubernetes/kubernetes/pull/122922 added support for memory pressure eviction singals on Windows in v1.31 and these are the corresponding doc updates.

/sig windows /area kubelet

Closes: #

marosset avatar Jul 29 '24 23:07 marosset

@marosset: The label(s) area/kubelet cannot be applied, because the repository doesn't have them.

In response to this:

Description

Issue

https://github.com/kubernetes/kubernetes/pull/122922 added support for memory pressure eviction singals on Windows in v1.31 and these are the corresponding doc updates.

/sig windows /area kubelet

Closes: #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jul 29 '24 23:07 k8s-ci-robot

Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
Latest commit 6fbfd77f3b6d2e56e96a2f6cecef2050d288e381
Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/66abb0081876aa0008adebe3

netlify[bot] avatar Jul 29 '24 23:07 netlify[bot]

Pull request preview available for checking

Built without sensitive environment variables

Name Link
Latest commit dc1e79536a353e9ba54100b5c7cf0adb2095306b
Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66a81f2967ae590008944060
Deploy Preview https://deploy-preview-47306--kubernetes-io-main-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jul 29 '24 23:07 netlify[bot]

Pull request preview available for checking

Built without sensitive environment variables

Name Link
Latest commit 6fbfd77f3b6d2e56e96a2f6cecef2050d288e381
Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66abb0081e7d650008e2cf21
Deploy Preview https://deploy-preview-47306--kubernetes-io-main-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jul 29 '24 23:07 netlify[bot]

/sig node

sftim avatar Jul 30 '24 08:07 sftim

/milestone v1.31

marosset avatar Jul 30 '24 16:07 marosset

@marosset: You must be a member of the kubernetes/website-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Website milestone maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jul 30 '24 16:07 k8s-ci-robot

/milestone 1.31 (already set tho)

sftim avatar Jul 30 '24 16:07 sftim

/lgtm for sig-windows

jsturtevant avatar Jul 30 '24 17:07 jsturtevant

LGTM label has been added.

Git tree hash: 5e9f3f6d917ec67aed61c8ee19125b19e4d9d91c

k8s-ci-robot avatar Jul 30 '24 17:07 k8s-ci-robot

@marrosset you can apply the suggestion from https://github.com/kubernetes/website/pull/47306#discussion_r1696529130 or you can, if you need to, skip that (would be nice to see a follow up PR though)

/hold

/approve

Unhold this to ship the docs as-is

sftim avatar Jul 30 '24 20:07 sftim

@marrosset you can apply the suggestion from #47306 (comment) or you can, if you need to, skip that (would be nice to see a follow up PR though)

/hold

/approve

Unhold this to ship the docs as-is

I'll make a new L3 heading for memory signals as well as filesystem signals - thanks

marosset avatar Jul 31 '24 16:07 marosset

/hold cancel /approve cancel

See https://github.com/kubernetes/website/pull/47306#pullrequestreview-2211212805

sftim avatar Jul 31 '24 22:07 sftim

This now needs a new (level 3?) heading before:

Some kubelet garbage collection features are deprecated in favor of eviction:

so that that phrase doesn't become counted as part of the list of node filesystems.

You can do a bigger refactor if you'd like, but something needs to happen. Sorry this can't merge yet.

Let me add that and see how it looks.

marosset avatar Jul 31 '24 22:07 marosset

This now needs a new (level 3?) heading before:

Some kubelet garbage collection features are deprecated in favor of eviction:

so that that phrase doesn't become counted as part of the list of node filesystems. You can do a bigger refactor if you'd like, but something needs to happen. Sorry this can't merge yet.

Let me add that and see how it looks.

@sftim - How does this look now? Unfortunately i'm not familiar enough with the feature to add much more context around the deprecations mentioned in that section.

marosset avatar Jul 31 '24 22:07 marosset

OK

/lgtm /approve

sftim avatar Aug 03 '24 11:08 sftim

LGTM label has been added.

Git tree hash: 59d8ec9b23402ccc73364f963e1297a6628cdc68

k8s-ci-robot avatar Aug 03 '24 11:08 k8s-ci-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 03 '24 11:08 k8s-ci-robot