website
website copied to clipboard
Updating Windows node eviction signals docs
Description
Issue
https://github.com/kubernetes/kubernetes/pull/122922 added support for memory pressure eviction singals on Windows in v1.31 and these are the corresponding doc updates.
/sig windows /area kubelet
Closes: #
@marosset: The label(s) area/kubelet cannot be applied, because the repository doesn't have them.
In response to this:
Description
Issue
https://github.com/kubernetes/kubernetes/pull/122922 added support for memory pressure eviction singals on Windows in v1.31 and these are the corresponding doc updates.
/sig windows /area kubelet
Closes: #
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Deploy Preview for kubernetes-io-vnext-staging processing.
| Name | Link |
|---|---|
| Latest commit | 6fbfd77f3b6d2e56e96a2f6cecef2050d288e381 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/66abb0081876aa0008adebe3 |
Pull request preview available for checking
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | dc1e79536a353e9ba54100b5c7cf0adb2095306b |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66a81f2967ae590008944060 |
| Deploy Preview | https://deploy-preview-47306--kubernetes-io-main-staging.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Pull request preview available for checking
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | 6fbfd77f3b6d2e56e96a2f6cecef2050d288e381 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66abb0081e7d650008e2cf21 |
| Deploy Preview | https://deploy-preview-47306--kubernetes-io-main-staging.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
/sig node
/milestone v1.31
@marosset: You must be a member of the kubernetes/website-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Website milestone maintainers and have them propose you as an additional delegate for this responsibility.
In response to this:
/milestone v1.31
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/milestone 1.31 (already set tho)
/lgtm for sig-windows
LGTM label has been added.
@marrosset you can apply the suggestion from https://github.com/kubernetes/website/pull/47306#discussion_r1696529130 or you can, if you need to, skip that (would be nice to see a follow up PR though)
/hold
/approve
Unhold this to ship the docs as-is
@marrosset you can apply the suggestion from #47306 (comment) or you can, if you need to, skip that (would be nice to see a follow up PR though)
/hold
/approve
Unhold this to ship the docs as-is
I'll make a new L3 heading for memory signals as well as filesystem signals - thanks
/hold cancel /approve cancel
See https://github.com/kubernetes/website/pull/47306#pullrequestreview-2211212805
This now needs a new (level 3?) heading before:
Some kubelet garbage collection features are deprecated in favor of eviction:
so that that phrase doesn't become counted as part of the list of node filesystems.
You can do a bigger refactor if you'd like, but something needs to happen. Sorry this can't merge yet.
Let me add that and see how it looks.
This now needs a new (level 3?) heading before:
Some kubelet garbage collection features are deprecated in favor of eviction:
so that that phrase doesn't become counted as part of the list of node filesystems. You can do a bigger refactor if you'd like, but something needs to happen. Sorry this can't merge yet.
Let me add that and see how it looks.
@sftim - How does this look now? Unfortunately i'm not familiar enough with the feature to add much more context around the deprecations mentioned in that section.
OK
/lgtm /approve
LGTM label has been added.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: sftim
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~content/en/docs/OWNERS~~ [sftim]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment