kubernetes
corrected priorityClassName used for static pod
fixes #46859
Corrected documentation to use priorityClassName for static pods instead of priorityClass and showed example yaml file.
Pull request preview available for checking
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | 52704c9bebb5742f8a3f4e35efc82399da55575e |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6769ac2aeb8a910008a44c76 |
| Deploy Preview | https://deploy-preview-47055--kubernetes-io-main-staging.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Does this work? I'd want evidence, because I think it's the wrong fix.
Instead, try setting a
priorityand apriorityClassName(thepriorityClassNamecan be any string, as far as I know).
Yes, it was tested and documented in the issue.
@ktvargo-ms: GitHub didn't allow me to request PR reviews from the following users: for, PR, review.
Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.
In response to this:
/cc @nate-double-u for PR review
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Hello @kubernetes/sig-node-leads, We would appreciate your feedback to ensure that these proposed changes are accurate. Thanks!
Hello @kubernetes/sig-node-leads, We would appreciate your feedback to ensure that these proposed changes are accurate. Thanks!
Sent ask to #sig-node Slack channel as well.
Hello @kubernetes/sig-node-leads, We would appreciate your feedback to ensure that these proposed changes are accurate. Thanks!
Sent ask to #sig-node Slack channel as well.
@sftim Based on discussion in https://github.com/kubernetes/kubernetes/issues/126542, is it agreed that...
Kubelet considers all static pods as critical regardless of their PodSpec.PriorityClassName. Static pods pass kubelet admission even if a node does not have enough resources. Users must ensure that they account for resources when creating static pods.
If in agreement, I will modify this PR.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from nate-double-u. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@sftim, @tengqm, @divya-mohan0209 @nate-double-u please review the latest changes
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
Hi @ktvargo-ms, thanks for this.
Since there are comments or feedback that haven’t been addressed in 2 or more weeks, I’m closing this PR. Please feel free to reopen it when you can work on it again.
/close
@nate-double-u: Closed this PR.
In response to this:
Hi @ktvargo-ms, thanks for this.
Since there are comments or feedback that haven’t been addressed in 2 or more weeks, I’m closing this PR. Please feel free to reopen it when you can work on it again.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.