website icon indicating copy to clipboard operation
website copied to clipboard

Consistent read from cache blogpost

Open serathius opened this issue 1 year ago • 9 comments

Blogpost for https://github.com/kubernetes/enhancements/issues/2340

serathius avatar Jun 21 '24 09:06 serathius

/cc @wojtek-t @ah8ad3 @p0lyn0mial @deads2k

serathius avatar Jun 21 '24 10:06 serathius

Pull request preview available for checking

Built without sensitive environment variables

Name Link
Latest commit f98d7598a600a3c8b940021fe991e47cad654084
Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66b62c45f69163000881bf65
Deploy Preview https://deploy-preview-46911--kubernetes-io-main-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 21 '24 15:06 netlify[bot]

/hold

pending assignment of publication date (by release comms)

we'll also keep this held until the v1.31 release has happened

sftim avatar Jun 23 '24 14:06 sftim

Thanks for creating this @serathius

pending assignment of publication date (by release comms) we'll also keep this held until the v1.31 release has happened

as @sftim pointed out, this is tied to the release so we wont be publishing until after the 1.31 release date. I'll be in touch soon once we have a finalized release blog schedule

a-mccarthy avatar Jun 24 '24 19:06 a-mccarthy

Hello @serathius thanks for writing this! I'm Abbie, comms lead for 1.31. The publication date for this blog is August 15th. Please update the filename and date with new date.

Are you able to address the review comments? let me know if i can help :)

a-mccarthy avatar Jul 25 '24 02:07 a-mccarthy

At the moment the feature was kicked out, we will be going for exception but still we struggle to find reviewers for changes.

serathius avatar Jul 25 '24 08:07 serathius

@serathius, ok. If this feature is removed from 1.31, please close this PR as well. thanks!

a-mccarthy avatar Jul 26 '24 13:07 a-mccarthy

There is a pending exception request https://groups.google.com/g/kubernetes-sig-api-machinery/c/LoKebQgJNJU

serathius avatar Jul 26 '24 13:07 serathius

We managed to snuck in https://github.com/kubernetes/kubernetes/pull/126469

serathius avatar Jul 31 '24 16:07 serathius

ping @wojtek-t @ah8ad3 @p0lyn0mial @deads2k for review

serathius avatar Jul 31 '24 18:07 serathius

Updated, please take another look. @liggitt @wojtek-t

serathius avatar Aug 01 '24 20:08 serathius

Addressed the comments

serathius avatar Aug 07 '24 16:08 serathius

@serathius left small nit suggestions. but otherwise lgtm

/lgtm

a-mccarthy avatar Aug 08 '24 13:08 a-mccarthy

LGTM label has been added.

Git tree hash: df8a519689decba713b26c45c635146abca9d24b

k8s-ci-robot avatar Aug 08 '24 13:08 k8s-ci-robot

/approve

:stop_sign: Do not unhold or merge until Kubernetes v1.31 is released :stop_sign:

sftim avatar Aug 08 '24 17:08 sftim

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 08 '24 17:08 k8s-ci-robot

thanks @serathius! If possible please squish your commits down to one

/lgtm

🛑 Do not unhold or merge until Kubernetes v1.31 is released 🛑

a-mccarthy avatar Aug 09 '24 13:08 a-mccarthy

LGTM label has been added.

Git tree hash: 6efafb538fcb2dc5b698a949b426cdeb1dc8ed72

k8s-ci-robot avatar Aug 09 '24 13:08 k8s-ci-robot

thanks @serathius! If possible please squish your commits down to one

Done

serathius avatar Aug 09 '24 14:08 serathius

thanks!

adding back the label /lgtm

a-mccarthy avatar Aug 09 '24 15:08 a-mccarthy

LGTM label has been added.

Git tree hash: 37c6e2c4e74426d95e8c070ce2837be3f9ffee63

k8s-ci-robot avatar Aug 09 '24 15:08 k8s-ci-robot

/unhold

Kubernetes v1.31 has been released.

dipesh-rawat avatar Aug 13 '24 16:08 dipesh-rawat