website icon indicating copy to clipboard operation
website copied to clipboard

Custom profiling in kubectl debug feature blog

Open ardaguclu opened this issue 1 year ago • 19 comments

Feature blog ~place holder~ article for https://github.com/kubernetes/enhancements/issues/4292

ardaguclu avatar Jun 21 '24 07:06 ardaguclu

Pull request preview available for checking

Built without sensitive environment variables

Name Link
Latest commit 4450722e099babc259a25fd1793946502964c50e
Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66b069e89754880008ed731a
Deploy Preview https://deploy-preview-46909--kubernetes-io-main-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 21 '24 07:06 netlify[bot]

/hold

pending assignment of publication date (by release comms)

we'll also keep this held until the v1.31 release has happened

sftim avatar Jun 23 '24 15:06 sftim

Hello @ardaguclu :wave: please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday July 16th 2024 18:00 PST. Thank you!

Princesso avatar Jul 08 '24 08:07 Princesso

This is ready for review. /cc @soltysh @eddiezane

ardaguclu avatar Jul 11 '24 10:07 ardaguclu

Hello @ardaguclu 🙂 , it's Edith Puclla from the 1.31 Release comms team.

A friendly reminder that the deadline for the blog to be ready for review is July 26, 2024.

Let me know if there's anything we can do to help with content, review, or anything else! 🙂

edithturn avatar Jul 16 '24 08:07 edithturn

Hello @ardaguclu 🙂 , it's Edith Puclla from the 1.31 Release comms team.

A friendly reminder that the deadline for the blog to be ready for review is July 26, 2024.

Let me know if there's anything we can do to help with content, review, or anything else! 🙂

@edithturn thank you for reminding. This PR is ready to merge actually, just waiting from approval from sig-docs. According to this comment https://github.com/kubernetes/website/pull/46909#issuecomment-2185044362, this PR is waiting from you about the publication date?.

ardaguclu avatar Jul 16 '24 09:07 ardaguclu

Contents lgtm. /lgtm Pending publish date assignment.

tengqm avatar Jul 16 '24 09:07 tengqm

LGTM label has been added.

Git tree hash: 4c6884d40785a187031ad837588a6dff7a0a899f

k8s-ci-robot avatar Jul 16 '24 09:07 k8s-ci-robot

Hello @ardaguclu 🙂 , it's Edith Puclla from the 1.31 Release comms team. A friendly reminder that the deadline for the blog to be ready for review is July 26, 2024. Let me know if there's anything we can do to help with content, review, or anything else! 🙂

@edithturn thank you for reminding. This PR is ready to merge actually, just waiting from approval from sig-docs. According to this comment #46909 (comment), this PR is waiting from you about the publication date?.

Hello @ardaguclu, Thank you so much for your update. This blog's publish date is August 22nd.

edithturn avatar Jul 26 '24 09:07 edithturn

@edithturn thank you, I've updated the PR with determined publication date.

ardaguclu avatar Jul 26 '24 09:07 ardaguclu

/hold cancel

ardaguclu avatar Jul 26 '24 09:07 ardaguclu

@tengqm could you please have a look at this PR?. Thank you.

ardaguclu avatar Jul 26 '24 09:07 ardaguclu

/lgtm

tengqm avatar Jul 26 '24 11:07 tengqm

LGTM label has been added.

Git tree hash: 6843fd3710fed5076a3110735f6fef0e354c750a

k8s-ci-robot avatar Jul 26 '24 11:07 k8s-ci-robot

/hold

see ~https://github.com/kubernetes/website/pull/46909#issuecomment-2252545970~ https://github.com/kubernetes/website/pull/46909#issuecomment-2185044362

sftim avatar Jul 26 '24 11:07 sftim

@sftim we have updated the publication date, see https://github.com/kubernetes/website/pull/46909#issuecomment-2252330343 Do you still think that we should hold this PR?

ardaguclu avatar Jul 26 '24 11:07 ardaguclu

Do you still think that we should hold this PR?

Yes, because it's like a logical AND; the other condition (has v1.31 been released yet) is not met.

sftim avatar Jul 26 '24 11:07 sftim

Do you still think that we should hold this PR?

Yes, because it's like a logical AND; the other condition (has v1.31 been released yet) is not met.

Thank you. You are right.

ardaguclu avatar Jul 26 '24 11:07 ardaguclu

@sftim thank you for your review. I've incorporated the changes you suggested. Could you PTAL?. Thank you.

ardaguclu avatar Aug 05 '24 06:08 ardaguclu

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divya-mohan0209, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 14 '24 06:08 k8s-ci-robot

I'd been hoping another contributor might LGTM this, but as that's not happened: /lgtm /hold cancel

sftim avatar Aug 14 '24 08:08 sftim

LGTM label has been added.

Git tree hash: ddb954dc5d0094f8045d410f6c3873b80ef645f9

k8s-ci-robot avatar Aug 14 '24 08:08 k8s-ci-robot