Add tutorial about running Pods with sidecar containers
/sig node
more questions about sidecars warranted me to write this down.
It was discussed at Sidecar WG meeting: https://docs.google.com/document/d/1E1guvFJ5KBQIGcjCrQqFywU9_cBQHRtHvjuqcVbCXvU/edit#bookmark=id.u4zmu7j9vn31
Pull request preview available for checking
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | 4bc6afb68c0d23065f0f47321e571f91a6a47624 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66b52ce69800d70008c5fb34 |
| Deploy Preview | https://deploy-preview-46825--kubernetes-io-main-staging.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
It's great that we want to help people learn about running sidecars.
How about adding a tutorial page, eg https://k8s.io/docs/tutorials/pod-sidecar-containers/?
Updated.
Any advice what does this may mean:
Error: error building site: assemble: "/opt/build/repo/content/en/docs/tutorials/configuration/pod-sidecar-containers.md:1:1": got positional parameter 'or'. Cannot mix named and positional parameters
/retitle Add tutorial about running Pods with sidecar containers
My key feedback is (still) the “questions in my mind” from https://github.com/kubernetes/website/pull/46825#pullrequestreview-2134319796
/label tide/merge-method-squash
@SergeyKanzhelev, can you please squash the commits.
/remove-label tide/merge-method-squash
@sftim I think I addressed most of comments. I really want this first step out. See https://kubernetes.slack.com/archives/C0EG7JC6T/p1723141448471749
I added a few follow up steps on top that can be done. @afro-coder I think it will be easiest if we can merge this PR and if you want to contribute, can do as a follow up.
great write, 100% correct regarding technicalities, thanks Sergey! /lgtm
LGTM label has been added.
/approve Let's kick this in and iterate over it.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: tengqm
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~content/en/docs/OWNERS~~ [tengqm]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment