website
website copied to clipboard
kubernetes
Add a deprecated flag and more details of EndpointSlice.addressType FQDN
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign divya-mohan0209 for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Pull request preview available for checking
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | 04a1622586f04a9a74e7f06edaa2f04949f61fa0 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6671109113884200088b142e |
| Deploy Preview | https://deploy-preview-46786--kubernetes-io-main-staging.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
@pegasas, it helps reviewers if the short PR title makes sense as it is. This one (“Add a deprecated flag and more details of the reason/alternatives for…”) is a big long and was also truncated.
Try something like "Mark foo as deprecated”. Concise is better.
@pegasas, it helps reviewers if the short PR title makes sense as it is. This one (“Add a deprecated flag and more details of the reason/alternatives for…”) is a big long and was also truncated.
Try something like "Mark foo as deprecated”. Concise is better.
Sure. I will correct the title to shorter one.
Current changes seems to be good.
@pegasas, It will be more clear if you can add below information also.
We can point to the official changelog or release announcement where the deprecation was mentioned. (I hope we mentioned it!)
The upstream changes https://github.com/kubernetes/kubernetes/pull/115160 was closed. Is it a blocker for this PR? /cc @T-Lakshmi @danwinship
For https://github.com/kubernetes/kubernetes/pull/115160#discussion_r1141382067, it is not first time to deprecate an enum value. i.e. the sig-storage team deprecated the Recycle reclaim policy. before they did that, they sent an email, please see Persistent Volume Recycler Deprecation Annoucement and referenced the email link in the https://github.com/kubernetes/kubernetes/blob/00236ae0d73d2455a2470469ed1005674f8ed61f/pkg/apis/core/types.go#L379. Unfortunately, they forgot to update the k8s.io/api/core/v1/types.go file.
/cc @sftim
cc @hzxuzhonghu @dprotaso @howardjohn https://github.com/istio/istio/issues/34995 was closed due to inactivity. https://github.com/istio/istio/blob/master/pilot/pkg/serviceregistry/kube/controller/endpointslice.go#L249 may need to be updated to reflect the changes in the upstream.
/close Closing because the upstream PR was closed. Feel free to reopen if appropriate.
@tengqm: Closed this PR.
In response to this:
/close Closing because the upstream PR was closed. Feel free to reopen if appropriate.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.