website
website copied to clipboard
kubernetes
[ar] Translate multiple tiny files to Arabic
Deploy Preview for kubernetes-io-ar-staging ready!
| Name | Link |
|---|---|
| Latest commit | 2d26c8844805011f8f2fee6d9c3686c6083b6036 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-io-ar-staging/deploys/6642a2bebed6f00008cdf5d0 |
| Deploy Preview | https://deploy-preview-46172--kubernetes-io-ar-staging.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Pull request preview available for checking
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | 2d26c8844805011f8f2fee6d9c3686c6083b6036 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6642a2be9efd0f0008227235 |
| Deploy Preview | https://deploy-preview-46172--kubernetes-io-main-staging.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
LGTM label has been added.
/assign @tengqm We cannot approve because of the _redirect file is out of our approve scope
LGTM label has been added.
Hi @tengqm,
Could you please help us to approve this PR?
The Arabic localization team does not have permission to approve changes in the file static/_redirects. We made a minor change to it, and that's why we are currently blocked.
The PR has already LGTMed for the Arabic, but please don't hesitate if you have any questions or need any information that can help.
We really appreciate it, Thank you.
The advice in https://github.com/kubernetes/website/pull/46172#issuecomment-2108995942 is useful but not the whole story.
SIG Docs leads are usually happy to add approval, but: as well as LGTM, please add an approval (using /approve) from an Arabic approver.
The PR won't merge, but Prow will still note the approval and that signifies to leads that it's OK to make the Arabic changes that are part of this PR. I don't think any SIG leads speak Arabic.
SIG Docs leads are usually happy to add approval, but: as well as LGTM, please add an approval (using
/approve) from an Arabic approver.
@adowair already added /approve but as you know because of the external file _redirects that's out of our scope of approve the bot did not add the approve label so that's need of the leads to approve https://github.com/kubernetes/website/pull/46172#issuecomment-2108995942
@sftim Can please help approve since the Ar community cannot approve changes in the file static/_redirects
@sftim Can please help approve since the Ar community cannot approve changes in the file
static/_redirects
You've got the wrong contributor I'm afraid. With the mechanism we use today, you should ask a tech lead or SIG chair to approve this change.
Given reviews from @sftim and at least one Arabic owner approving these changes (@adowair), I'm adding my approval as a SIG Co-Chair to unblock this localization work 🤝 /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: adowair, natalisucks
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [natalisucks]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@mboukhalfa @adowair In future, please feel free to use the alias @kubernetes/sig-docs-leads to ping all tech leads/chairs when you need an admin-level change. You can also ping our subproject owners @seokho-son and @a-mccarthy who can help triage 😸