website
website copied to clipboard
Update hello-minikube.md
Add warning about kubectl expose on agnhost
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign tengqm for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
Pull request preview available for checking
Built without sensitive environment variables
Name | Link |
---|---|
Latest commit | a3e1fef3a04fdd8addffc7139de2c1b4f53d3702 |
Latest deploy log | https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/667da4b1c28bdc00083389cb |
Deploy Preview | https://deploy-preview-46140--kubernetes-io-main-staging.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@cjcullen Whenever you get a chance, could you please take a look at the reviewers' feedback and respond to them? Thanks!
@cjcullen would you be willing to wrap the warning per the feedback in https://github.com/kubernetes/website/pull/46140/files#r1588795257 ?
@sftim - I've a question. If the suggestion is to wrap the lines then how come at lines 146 to 148, the same is not done for note
or for that matter anywhere else?
{{< note >}}
Replace hello-node-5f76cf6ccf-br9b5
in the kubectl logs
command with the name of the pod from the kubectl get pods
command output.
{{< /note >}}
If the suggestion is to wrap the lines then how come at lines 146 to 148, the same is not done for
note
or for that matter anywhere else?
The convention, in general, is to treat markdown documentation as code, where we value not only how the output looks like, but also the readability of the source. The suggestion as I see it is not a blocker. Another example is the wrapping of long lines in ".md" files. These wrapping would not affect the rendered web pages, but manual wrapping of long lines help improve readability, and it helps tracking changes on a line-by-line basis (that is how git diff works), and it helps the downstream localization team to track upstream changes.
If the suggestion is to wrap the lines then how come at lines 146 to 148, the same is not done for
note
or for that matter anywhere else?The convention, in general, is to treat markdown documentation as code, where we value not only how the output looks like, but also the readability of the source. The suggestion as I see it is not a blocker. Another example is the wrapping of long lines in ".md" files. These wrapping would not affect the rendered web pages, but manual wrapping of long lines help improve readability, and it helps tracking changes on a line-by-line basis (that is how git diff works), and it helps the downstream localization team to track upstream changes.
Thanks for such an excellent clarification, Qiming 🙏🏻
The changes look good to me. https://deploy-preview-46140--kubernetes-io-main-staging.netlify.app/docs/tutorials/hello-minikube/#create-a-service /lgtm
LGTM label has been added.
@cjcullen updated the PR, so we can approve this PR, as it was opened first.
CC @sftim @dipesh-rawat WDYT?
/lgtm
Thanks for this @cjcullen /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: nate-double-u, sandeepkanabar
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~content/en/docs/OWNERS~~ [nate-double-u]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment