website icon indicating copy to clipboard operation
website copied to clipboard

[ja] update the term "Node" in `/docs/concepts/scheduling-eviction/taint-and-toleration.md`

Open Okabe-Junya opened this issue 9 months ago • 5 comments

Feature Description

  • Fix the term "Node/node" to "ノード" in /docs/concepts/scheduling-eviction/taint-and-toleration.md

Ref

https://kubernetes.io/ja/docs/contribute/localization/#terminology

ただし、ノード(Node)に関しては明確にKubernetesとしてのNodeリソース(例: kind: Nodeやkubectl get nodes)を指していないのであれば、「ノード」と表記してください。

Okabe-Junya avatar Apr 29 '24 18:04 Okabe-Junya

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign inductor for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Apr 29 '24 18:04 k8s-ci-robot

/label refactor /assign nasa9084

Okabe-Junya avatar Apr 29 '24 18:04 Okabe-Junya

Pull request preview available for checking

Built without sensitive environment variables

Name Link
Latest commit 129d9b84d4c716591cf2e60ec52787a78c25a137
Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/662fe4b616fcd90008f866c0
Deploy Preview https://deploy-preview-46076--kubernetes-io-main-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 29 '24 18:04 netlify[bot]

Deploy preview:

  • https://deploy-preview-46076--kubernetes-io-main-staging.netlify.app/ja/docs/concepts/scheduling-eviction/taint-and-toleration/

Okabe-Junya avatar Apr 29 '24 18:04 Okabe-Junya

/hold

ref. https://github.com/kubernetes/website/pull/46076#pullrequestreview-2039561280

Okabe-Junya avatar May 05 '24 01:05 Okabe-Junya

/unhold

ref. https://github.com/kubernetes/website/pull/46076#discussion_r1599297071

PTAL again @atoato88 cc @kubernetes/sig-docs-ja-owners to move this PR forward :D

Okabe-Junya avatar May 14 '24 06:05 Okabe-Junya

/lgtm

atoato88 avatar May 14 '24 06:05 atoato88

LGTM label has been added.

Git tree hash: 72e2d9964378e446847cd567ab963349d09896e1

k8s-ci-robot avatar May 14 '24 06:05 k8s-ci-robot

「ノード」という単語が日本語でもカタカナで普通に使われてるというところが、各レビュアーの解釈の揺れにつながってる感じがしますよね。

あきらかにNodeリソースであるという解釈しかありえない部分以外では見る時、見る人によってどちらも正しく思えるような気がしていて、難しいですね。

atoato88 avatar May 14 '24 06:05 atoato88

/approve

inductor avatar May 27 '24 07:05 inductor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inductor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 27 '24 07:05 k8s-ci-robot