website icon indicating copy to clipboard operation
website copied to clipboard

Contribute as sig-docs reviewer blog post

Open ricardoamaro opened this issue 9 months ago â€ĸ 13 comments

This blog post aims to attract open-source contributors with Git/GitHub knowledge to become Kubernetes SIG-Docs reviewers.

cc/ @sftim

ricardoamaro avatar Apr 28 '24 20:04 ricardoamaro

Pull request preview available for checking

Built without sensitive environment variables

Name Link
Latest commit 52ebe0472501fcd51ab84e071ac46f2ebca4a585
Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66454c164917e80007ab529b
Deploy Preview https://deploy-preview-46054--kubernetes-io-main-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 28 '24 21:04 netlify[bot]

Nice!

/lgtm

stmcginnis avatar Apr 28 '24 21:04 stmcginnis

LGTM label has been added.

Git tree hash: abcbbccaed75f2746ceb0346635a6a859cce2070

k8s-ci-robot avatar Apr 28 '24 21:04 k8s-ci-robot

/remove-language pt /remove-area localization

dipesh-rawat avatar Apr 28 '24 23:04 dipesh-rawat

Amazing work coming up with this blog! I've included some review comments after a quick read-through.

This could also make a valuable addition to the contributor site's blog (Site: https://www.kubernetes.dev/blog/ ; Repo: https://github.com/kubernetes/contributor-site) plus this needs a formal publication date from the blog team.

+1 to this, you can publish this on kubernetes.dev and it can be mirrored on kubernetes.io

reylejano avatar Apr 30 '24 18:04 reylejano

Moved to https://github.com/kubernetes/contributor-site/pull/496

ricardoamaro avatar Apr 30 '24 19:04 ricardoamaro

/hold

  • pending confirmation of publication date
  • pending reviews on the K8s contributor blog original of this article

OK to unhold when both are covered

sftim avatar Apr 30 '24 20:04 sftim

/remove-language ja /remove-language zh

sftim avatar Apr 30 '24 20:04 sftim

:information_source: Reviews should be upstream if possible.

sftim avatar May 02 '24 13:05 sftim

ℹī¸ Reviews should be upstream if possible.

ah, i now see that this is also on the contributor site, and the reviews on both are different – i hadn't seen this earlier, my apologies. given @jberkus' comments on the contributor site version, lets consider the contributor site verision to be the main source/area for work, and refrain from further reviews here until Josh's concern is addressed.

natalisucks avatar May 02 '24 13:05 natalisucks

Thank you. I'll move all the suggestions to https://github.com/kubernetes/contributor-site/pull/496

ricardoamaro avatar May 02 '24 21:05 ricardoamaro

Confirmed this is a mirror of what's merged on the contributor-site, https://github.com/kubernetes/contributor-site/blob/master/content/en/blog/2024/contribute-as-sig-docs-reviewer.md /approve

reylejano avatar May 15 '24 21:05 reylejano

We can unhold this and fix the filename post merge. Not ideal but it feels like the least bad thing to do.

@dipesh-rawat I know you already have many tasks in flight. Are you willing to file a good-first-issue about doing that rename?

sftim avatar May 15 '24 23:05 sftim

Feedback from https://github.com/kubernetes/website/pull/46054#pullrequestreview-2035560291 looks fixed.

/hold cancel

sftim avatar May 16 '24 00:05 sftim

/lgtm /approve

(as a blog editor)

sftim avatar May 16 '24 00:05 sftim

LGTM label has been added.

Git tree hash: 6a8784704cb0e5e0ad97f5dc246f2c892630f520

k8s-ci-robot avatar May 16 '24 00:05 k8s-ci-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano, sftim, tcarrondo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 16 '24 00:05 k8s-ci-robot