website
website copied to clipboard
Contribute as sig-docs reviewer blog post
This blog post aims to attract open-source contributors with Git/GitHub knowledge to become Kubernetes SIG-Docs reviewers.
cc/ @sftim
Pull request preview available for checking
Built without sensitive environment variables
Name | Link |
---|---|
Latest commit | 52ebe0472501fcd51ab84e071ac46f2ebca4a585 |
Latest deploy log | https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66454c164917e80007ab529b |
Deploy Preview | https://deploy-preview-46054--kubernetes-io-main-staging.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Nice!
/lgtm
LGTM label has been added.
/remove-language pt /remove-area localization
Amazing work coming up with this blog! I've included some review comments after a quick read-through.
This could also make a valuable addition to the contributor site's blog (Site: https://www.kubernetes.dev/blog/ ; Repo: https://github.com/kubernetes/contributor-site) plus this needs a formal publication date from the blog team.
+1 to this, you can publish this on kubernetes.dev and it can be mirrored on kubernetes.io
Moved to https://github.com/kubernetes/contributor-site/pull/496
/hold
- pending confirmation of publication date
- pending reviews on the K8s contributor blog original of this article
OK to unhold when both are covered
/remove-language ja /remove-language zh
:information_source: Reviews should be upstream if possible.
âšī¸ Reviews should be upstream if possible.
ah, i now see that this is also on the contributor site, and the reviews on both are different â i hadn't seen this earlier, my apologies. given @jberkus' comments on the contributor site version, lets consider the contributor site verision to be the main source/area for work, and refrain from further reviews here until Josh's concern is addressed.
Thank you. I'll move all the suggestions to https://github.com/kubernetes/contributor-site/pull/496
Confirmed this is a mirror of what's merged on the contributor-site, https://github.com/kubernetes/contributor-site/blob/master/content/en/blog/2024/contribute-as-sig-docs-reviewer.md /approve
We can unhold this and fix the filename post merge. Not ideal but it feels like the least bad thing to do.
@dipesh-rawat I know you already have many tasks in flight. Are you willing to file a good-first-issue about doing that rename?
Feedback from https://github.com/kubernetes/website/pull/46054#pullrequestreview-2035560291 looks fixed.
/hold cancel
/lgtm /approve
(as a blog editor)
LGTM label has been added.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: reylejano, sftim, tcarrondo
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~content/en/blog/OWNERS~~ [reylejano,sftim]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment