website
website copied to clipboard
kubernetes
Fixed typo in configure-liveness-readiness-startup-probes.md
I was reading the docs regarding liveness and observed that there was in fact a typo. So this change is just modifying the content of a markdown.
Thanks 😄
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Welcome @Kavignon!
It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes/website has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign tengqm for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Pull request preview available for checking
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | 8ff380d0b91820bf8f201151088fa01ff512c57d |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66213ea70088a60008fea69a |
| Deploy Preview | https://deploy-preview-45918--kubernetes-io-main-staging.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thanks @Kavignon , but failureThreshold is actually a thing that this is referring to. There's maybe still a bug here though that the doc is referring to the name before it has been introduced.
Part of the docs policy is not to format the names (failureThreshold vs failureThreshold), which I think kind of contributes to this being interpreted as a typo here. But maybe a link to the definition or a reordering of some content might make it more clear?
Agree with @stmcginnis that this isn't completely a typo. I think there are potentially improvements that could be made to the page outside of that though if you'd like to keep this open for further changes.
Also please look through the page to find further improvement to make the pr more relevant as this change is very small.
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
@tengqm: Closed this PR.
In response to this:
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.