website icon indicating copy to clipboard operation
website copied to clipboard

Update kube-proxy subtleties blog article

Open anfernee opened this issue 10 months ago • 7 comments

Fix typos. Kudos to [email protected] who pointed out the typos to me via email.

anfernee avatar Apr 10 '24 03:04 anfernee

Pull request preview available for checking

Built without sensitive environment variables

Name Link
Latest commit 5d52413779e1c1534165f942f5e52702d48e7905
Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/664be67936cdfd0008158366
Deploy Preview https://deploy-preview-45813--kubernetes-io-main-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 10 '24 03:04 netlify[bot]

/lgtm

salaxander avatar Apr 22 '24 21:04 salaxander

LGTM label has been added.

Git tree hash: 64918ccfe7036d709c9bb728cc3d7542659a1376

k8s-ci-robot avatar Apr 22 '24 21:04 k8s-ci-robot

/retitle Update kube-proxy subtleties blog article

When we update blog articles, we typically:

  • include a visible note about the update
  • avoid updating articles that are more than 1 year old, unless they are marked evergreen: true

sftim avatar Apr 22 '24 22:04 sftim

New changes are detected. LGTM label has been removed.

k8s-ci-robot avatar Apr 23 '24 00:04 k8s-ci-robot

/approve

tengqm avatar May 04 '24 01:05 tengqm

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 04 '24 01:05 k8s-ci-robot

@anfernee Could you please take a moment to address the review comment (here) about changing month in the edit note when you have a chance? Thanks!

dipesh-rawat avatar May 20 '24 23:05 dipesh-rawat

Yongkun Anfernee Gui Could you please take a moment to address the review comment (here) about changing month in the edit note when you have a chance? Thanks!

Applied the change. Sorry for the late reply.

anfernee avatar May 21 '24 00:05 anfernee

Hi @anfernee, thanks for this; however, I'm closing it as it is (as mentioned above) a change to a very old blog entry, and we usually don't edit old blog posts older than a year. Also, rather than adding a textual note describing the error, it would be better to correct the image. This PR also appears stale, as it has been over 30 days since anyone has commented.

Thanks for your work on this, and thanks to the reviewers!

/close

nate-double-u avatar Jul 12 '24 22:07 nate-double-u

@nate-double-u: Closed this PR.

In response to this:

Hi @anfernee, thanks for this; however, I'm closing it as it is (as mentioned above) a change to a very old blog entry, and we usually don't edit old blog posts older than a year. Also, rather than adding a textual note describing the error, it would be better to correct the image. This PR also appears stale, as it has been over 30 days since anyone has commented.

Thanks for your work on this, and thanks to the reviewers!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jul 12 '24 22:07 k8s-ci-robot