website icon indicating copy to clipboard operation
website copied to clipboard

Update KubeProxyWinkernelConfiguration sourceVip configuration docs

Open tzifudzi opened this issue 10 months ago • 10 comments

What will change

This PR updates the documentation for KubeProxyWinkernelConfiguration to include a note about the precedence regarding the sourceVip configuration on Windows nodes operating in overlay networking mode. Specifically, the documentation change clarifies that if the sourceVip configuration is not explicitly specified in the KubeProxyWinkernelConfiguration, kube-proxy will attempt to fetch the IP address from a well-known Host Networking Service (HNS) endpoint named source_vip.

Why this change

This update aims to bring awareness to a new well-known HNS endpoint name introduced in the accompanying change https://github.com/kubernetes/kubernetes/pull/123394. With this new documentation change, one should be able to determine and choose to set the sourceVip explicitly by specifying it in the kube-proxy configuration, or by using creating an HNS endpoint on the Windows node with the name source_vip which will be automatically detected when kube-proxy starts.

/sig windows cc @jsturtevant

References

  • https://github.com/kubernetes/kubernetes/pull/123394

tzifudzi avatar Apr 09 '24 05:04 tzifudzi

/hold This documentation change should only be merge if accompanying change https://github.com/kubernetes/kubernetes/pull/123394 is merged.

tzifudzi avatar Apr 09 '24 05:04 tzifudzi

Pull request preview available for checking

Built without sensitive environment variables

Name Link
Latest commit 6ba47275527e5e528d4f7527633367706d829335
Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6614d042f0113e0008352564
Deploy Preview https://deploy-preview-45808--kubernetes-io-main-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 09 '24 05:04 netlify[bot]

Is this a new feature/change that will be effective in 1.31? Please target the PR at dev-1.31 branch if so.

tengqm avatar May 04 '24 01:05 tengqm

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 02 '24 01:08 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Sep 01 '24 02:09 k8s-triage-robot

/close Feel free to reopen this and continue the work. It has been a few months since last response.

tengqm avatar Sep 10 '24 03:09 tengqm

@tengqm: Closed this PR.

In response to this:

/close Feel free to reopen this and continue the work. It has been a few months since last response.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Sep 10 '24 03:09 k8s-ci-robot

Apologies for late response. I will be resuming work on this PR and targeting it for the 1.32 release. /reopen

tzifudzi avatar Sep 23 '24 03:09 tzifudzi

@tzifudzi: Reopened this PR.

In response to this:

Apologies for late response. I will be resuming work on this PR and targeting it for the 1.32 release. /reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Sep 23 '24 03:09 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign sftim for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 23 '24 03:09 k8s-ci-robot