website icon indicating copy to clipboard operation
website copied to clipboard

Improve "Reserve Compute Resources for System Daemons" doc

Open sathieu opened this issue 10 months ago โ€ข 3 comments

  • ๐Ÿ“– Add a link to how to change kubelet settings
  • ๐Ÿ—‘๏ธ Remove mention of k8s 1.17
  • ๐Ÿงน Remove deprecated CLI flags and replace by KubeletConfiguration settings ; and properly document defaults
  • ๐Ÿ‘ properly document enforcement (enforceNodeAllocatable should be set)

sathieu avatar Apr 04 '24 12:04 sathieu

Pull request preview available for checking

Built without sensitive environment variables

Name Link
Latest commit 2acc4f72c74326838208831d10531d96a5d92e7a
Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/665e23dd23ccba00086fc7d8
Deploy Preview https://deploy-preview-45771--kubernetes-io-main-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 04 '24 12:04 netlify[bot]

Appart from the included changes, I find the Kube Reserved and System Reserved section misleading.

I first thought that those would map to an amount of reserved memory and cpu (i.e. requests), while the current behavior is to set limits.

sathieu avatar Apr 04 '24 12:04 sathieu

Thanks @tengqm. I've applied your suggestions.

sathieu avatar May 07 '24 10:05 sathieu

/label tide/merge-method-squash

tengqm avatar May 07 '24 12:05 tengqm

@tengqm How can we move this PR forward?

sathieu avatar May 22 '24 19:05 sathieu

@sathieu Please check the feedback about headings and fix it if possible.

tengqm avatar May 24 '24 00:05 tengqm

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jun 03 '24 20:06 k8s-ci-robot

@tengqm @dipesh-rawat Sorry for the delay. I addressed the last comment. Back to you!

sathieu avatar Jun 03 '24 20:06 sathieu

/lgtm

tengqm avatar Jun 04 '24 01:06 tengqm

LGTM label has been added.

Git tree hash: b69933bc8f72ae5b7e2b104da4ba1671e5c18392

k8s-ci-robot avatar Jun 04 '24 01:06 k8s-ci-robot