website
website copied to clipboard
kubernetes
[bn] Launch Bengali localization
This PR is created to merge dev-1.24-bn.1 into main branch
by fixing : #44993
Tracking issue: #31677
Pull request preview available for checking
| Name | Link |
|---|---|
| Latest commit | 3eced4f1ca0800fe00f093634de1523a88019eb6 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/663d0f00179d1c0008f234cc |
| Deploy Preview | https://deploy-preview-45009--kubernetes-io-main-staging.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
@itsPronay Most of the files are outdated. My team and I are starting fresh. We're working on updating those files and localizing others . Feel free to reach out to me if you notice anything to Change/Update/Localize or if you find any Mistakes . I'll take the necessary steps to fix them. .
@itsPronay as a courtesy, we avoid reviewing work marked as draft; there are exceptions and I do sometimes offer early feedback.
You are welcome to file new issues to record work that needs doing ahead of launching Bengali, including any recommendation to rework something already localized.
@asem-hamid: No presubmit jobs available for kubernetes/website@main
In response to this:
/test
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
There is a Header Rule Error because the glossary term_id sidecar-container is missing.
@dipesh-rawat Is there a way to view all errors at once? I believe there may still be more errors there.
Is there a way to view all errors at once? I believe there may still be more errors there.
Typically, the build preview deploy logs (here) should display all errors encountered. Right now, it's only showing the missing upcoming-releases shortcode file error. It's important to note that with each new commit added to the PR branch, the build preview reruns, which might uncover additional failures. Predicting these errors in advance can be challenging, but the logs should capture them all.
Deploy Preview for kubernetes-io-bn-staging ready!
| Name | Link |
|---|---|
| Latest commit | 3eced4f1ca0800fe00f093634de1523a88019eb6 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-io-bn-staging/deploys/663d0f0060d3560009f8e73b |
| Deploy Preview | https://deploy-preview-45009--kubernetes-io-bn-staging.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@mitul3737: GitHub didn't allow me to request PR reviews from the following users: mitul3737.
Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.
In response to this:
This PR aims to launch the Bengali localization of the Kubernetes website by merging the dev-1.24-bn.1 branch into the main branch.
We have completed all the necessary content and made the required adjustments to launch the Kubernetes website in Bangla.
- https://github.com/kubernetes/website/issues/44993
We also have a perfect deploy preview :
- https://deploy-preview-45009--kubernetes-io-main-staging.netlify.app/bn/
dev-1.24-bn.1 has been fully reviewed by :
/cc @asem-hamid /cc @mitul3737 /cc @sajibAdhi
We kindly request review and approval from
- sig-docs-localization-reviewers
/cc @a-mccarthy /cc @seokho-son
- sig-docs-leads
/cc @divya-mohan0209
/cc @natalisucks /cc @reylejano /cc @sftimThank you for your cooperation and support!
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
I've reviewed all content outside content/bn such as hugo.toml, i18n, static, OWNERS_ALIASES, and README.md, and everything looks good to me. +Netlify preview works nicely.
I believe content/bn meets the minimal requirements, and individual contents inside content/bn have already been reviewed by Bn reviewers:
- asem-hamid
- Imtiaz1234
- mitul3737
- rajibmitra
Therefore, the content inside this PR, LGTM!
However, I am concerned about the commit history. The 903 commits in the upstream dev-1.24-bn.1 are not following the SIG-Docs commit squashing policy. dev-1.24-bn.1 contains too many redundant or irrelevant commits.
My suggestion is to open another PR with one squashed commit for this first release of the Bengali localization.
- For instance, see #44980
Regarding my suggestion for commit squashing, I hope to follow a decision from SIG-Docs leads, and emeritus leads. I'd like to call @kubernetes/sig-docs-leads here to finalize the first live of Bengali localization. :)
I also reviewed files outside content/bn: OWNERS_ALIASES, README.md, hugo.toml, _redirects. I have one minor suggestion
Thank you for addressing my comment /lgtm /assign @reylejano @natalisucks @divya-mohan0209 @seokho-son @a-mccarthy
LGTM label has been added.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: divya-mohan0209
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [divya-mohan0209]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@seokho-son : Regarding squashing of commits, please could you advise on the precedent followed previously for other localisation go-lives that you have been involved in?
Hi @divya-mohan0209, I offered some advice but was not directly involved with the release of previous languages, except for Korean. I just reviewed how we've managed similar cases in the past.
- https://github.com/kubernetes/website/pull/12998 (67 commits for 270 files)
- https://github.com/kubernetes/website/pull/18569 (3 commits)
(I assume the following languages were based on a previous localization guide)
- https://github.com/kubernetes/website/pull/16404 (35 commits)
- https://github.com/kubernetes/website/pull/13543 (34 commits)
- https://github.com/kubernetes/website/pull/13822 (12 commits)
- https://github.com/kubernetes/website/pull/18419 (5 commits)
- https://github.com/kubernetes/website/pull/10471 (1 commit)
However, my concern is not the number of commits but rather the presence of too many redundant or irrelevant commits in dev-1.24-bn.1, possibly included by the GitHub review suggestion UI as well.
It seems that many localization teams, including the Korean team, have been making efforts to manage commits effectively.
- https://github.com/kubernetes/website/pull/18226 (1 commit)
- https://github.com/kubernetes/website/pull/29998
I'm okay with it if there have been previous precedents of it working successfully. Again, this is an improvement in how we localise docs that will need general consensus and must be documented. Given the time constraints around the PR, I suggest the following.
- I'd like the other co-chairs, leads, and emeritus leads to chime in on this improvement as the bare minimum. I'm tagging @reylejano @natalisucks @sftim @a-mccarthy @dipesh-rawat here since they have previously been involved/tagged here for reviews.
- By EOD, we will proceed with the recommended approach if a minimum quorum of 50% of the folks tagged in point number 1 assent to this improvement without any technical/procedural concerns.
- If it succeeds without glitches, we will showcase this at our next localisation meeting and PR it as a recommendation in our docs.
Although we'd like to see commits done well (it makes the repo easier to manage), if they haven't been then we mostly need to accept that.
I am happy to see Bengali launch if the only qualm about launching it is the commit history on that branch and not follow our norms (not rules, norms) around squashing.
As an aside, watch out for commits that touch other parts of the tree and are then reverted within the same PR. That kind of commit makes merges and rebases a pain for everyone else.
(I'm not seeing that here)
I'm also happy to see the Bengali localization launch and for us to document our desired approach for teams around commits more broadly before stricter reinforcement.
Thanks to our various leads for their reviews here! ❤️
Ok! I think we've reached a consensus. Let me release the hold and let's look forward to the new language for k8s.io!
/lgtm /hold cancel
Thank you so much for your review, approval, and effort, which allowed us to launch it so quickly.
@seokho-son , @reylejano , @divya-mohan0209 , @sftim , @natalisucks
I also want to thank @seokho-son and @sftim for all the help and guidance from the beginning until now during the localization progress.