website
website copied to clipboard
kubernetes
Update encryption-at-rest task page
Revise Encrypting Secret Data at Rest [preview]
This is an overall PR and I am splitting out smaller PRs - scroll down to see more
- ~Use HTML table [preview] in place of harder-to-read Markdown version.~
- assume that encryption at rest is available; no need to check cluster version is compatible
- clarify purpose of task
- use more glossary tooltips
- improve page headings
- style tweaks
Split PRs (current / recent set):
- ~https://github.com/kubernetes/website/pull/44622~
- ~https://github.com/kubernetes/website/pull/44951~
Pull request preview available for checking
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | c91ebf4498a55cbd94318db8071ee58b9f16cdc0 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6635077f5fd5b7000936e697 |
| Deploy Preview | https://deploy-preview-33285--kubernetes-io-main-staging.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Mark this issue or PR as fresh with
/remove-lifecycle stale - Mark this issue or PR as rotten with
/lifecycle rotten - Close this issue or PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
Hey @sftim , believe you'll need to rebase this against main all over again. I know you're swamped, please feel free to do this whenever you have some cycles free.
Hi @sftim . Generally, good stuff. I wrote up a few areas to look into. Is a tech review a good idea?
@sftim @tengqm Are the main comments answered? Is there more to do? What about a tech review? @kubernetes/sig-security-pr-reviews
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: sftim / name: Tim Bannister (20d7c73d02504927815e16c5522df0a569b535ab, c91ebf4498a55cbd94318db8071ee58b9f16cdc0)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
I think I'll need to turn this into an overall PR and split the changes out into smaller individual PRs. I'll focus on the CLA fix for those smaller PRs, once I have time to make them.
/hold
I'll split off PRs from this and wait for those to be reviewed. Should be done within a year or so, potentially less.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from sftim. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
:thinking:, prompted by https://github.com/kubernetes/website/pull/33285/files#r1114309593
I would like to end up with:
- “Encryption in Kubernetes” (concept page)
- “Change the encryption key for API encryption at rest” (task page)
- “Set up API encryption at rest” (task page)
- “Migrate away from API encryption at rest” (task page, go back to identity for some or all APIs).
@sftim , If you have another pull request that has this content, would you close this pull request. It will help us clean up outstanding pull requests. Thanks
This is an overall PR that I am slowly splitting out into smaller PRs. I plan to leave this open because:
- it may shrink to a reviewable size - as the split-out PRs merge, there is less left to do
- the deploy preview lets people see changes from a split-out PR in their wider context
For an example of a split-out PR, see https://github.com/kubernetes/website/pull/42882 or https://github.com/kubernetes/website/pull/42883
To move this forward, please review or approve https://github.com/kubernetes/website/pull/44085.
To move this forward, please review or approve https://github.com/kubernetes/website/pull/44532.
To move this forward, please review or approve https://github.com/kubernetes/website/pull/44532 or https://github.com/kubernetes/website/pull/44622.
To move this forward, please review or approve https://github.com/kubernetes/website/pull/44622 or https://github.com/kubernetes/website/pull/44675.
To move this forward, please review https://github.com/kubernetes/website/pull/44622, or suggest another part of the page that I can split out.
I'd be happy to see these changes land in one batch, if that's feasible; if not, please see PR https://github.com/kubernetes/website/pull/44622
See https://github.com/kubernetes/website/pull/44622 which I recommend reviewing before this one.
@sftim: Closed this PR.
In response to this:
Doubt I'll find time to finish this.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.