website icon indicating copy to clipboard operation
website copied to clipboard

CSR `.spec.usages` - add definition table for valid values

Open brsolomon-deloitte opened this issue 4 years ago • 13 comments

This is a Feature Request

What would you like to be added

It would be useful to see https://kubernetes.io/docs/reference/access-authn-authz/certificate-signing-requests/ do one or possibly two things:

  • Display a 2-column table that gives the valid values of csr.spec.usages and a short definition of each in the second column
  • A more prominent link to https://datatracker.ietf.org/doc/html/rfc5280#section-4.2.1.3 as defining some of the usages. (Though notedly is does not define all; for example "ipsec end system" doesn't seem to be described directly there.) This doc links to that RFC but not in referneces to csr.spec.usages.

Why is this needed

The page referenced above does not show a clear mapping of each usage type to its definition/usage. Similarly, kubectl explain csr.spec.usages shows a list of valid values, but does not explain what any are, besides alluding to which are used in TLS client versus server certs. Many of these such as "content commitment" are not inherently obvious from name only.

Comments

For example:

Usage Definition
"signing" xxx
"email protection" xxx

brsolomon-deloitte avatar Nov 21 '21 23:11 brsolomon-deloitte

/sig auth /language en

sftim avatar Nov 22 '21 13:11 sftim

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Feb 20 '22 13:02 k8s-triage-robot

/triage accepted /remove-lifecycle stale

@brsolomon-deloitte care to open a PR 😄 ?

enj avatar Feb 28 '22 17:02 enj

@enj I have since discovered https://pkg.go.dev/k8s.io/api/certificates/v1beta1#KeyUsage which serves to enumerate the possible values, but I myself am not well-versed in what each of these is used for. (The "Description" field.) Is there an external source(s) that contains these definitions?

brsolomon-deloitte avatar Feb 28 '22 21:02 brsolomon-deloitte

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar May 29 '22 22:05 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Jun 28 '22 22:06 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar Jul 28 '22 23:07 k8s-triage-robot

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jul 28 '22 23:07 k8s-ci-robot

/reopen /remove-lifecycle rotten /lifecycle frozen

Seems useful to decide one way or another what to do - either accept it, or decide against.

sftim avatar Jul 30 '23 22:07 sftim

@sftim: Reopened this issue.

In response to this:

/reopen /remove-lifecycle rotten /lifecycle frozen

Seems useful to decide one way or another what to do - either accept it, or decide against.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jul 30 '23 22:07 k8s-ci-robot

/sig security

sftim avatar Jul 30 '23 22:07 sftim

/retitle CSR .spec.usages - add definition table for valid values

sftim avatar Jul 30 '23 22:07 sftim

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

k8s-triage-robot avatar Jul 29 '24 22:07 k8s-triage-robot