test-infra icon indicating copy to clipboard operation
test-infra copied to clipboard

feat: Add tests with higher version skew for compatibility version

Open michaelasp opened this issue 5 months ago • 6 comments

Now that the alpha.1 tag has been cut for K8s, we have had emulated version added for 3 releases. Add tests for that use case as the KEP states that we should be able to support up to N-3 version skew for emulated versions.

michaelasp avatar Jun 24 '25 16:06 michaelasp

Hi @michaelasp. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jun 24 '25 16:06 k8s-ci-robot

/cc @aaron-prindle /cc @BenTheElder

michaelasp avatar Jun 24 '25 16:06 michaelasp

/cc @Jefftree

michaelasp avatar Jun 24 '25 17:06 michaelasp

/ok-to-test

Jefftree avatar Jun 25 '25 15:06 Jefftree

/hold /lgtm

aaron-prindle avatar Jun 25 '25 17:06 aaron-prindle

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, michaelasp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jun 27 '25 17:06 k8s-ci-robot

/unhold

aaron-prindle avatar Jul 01 '25 20:07 aaron-prindle

@michaelasp: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key compatibility-versions-e2e.yaml using file config/jobs/kubernetes/sig-testing/compatibility-versions-e2e.yaml

In response to this:

Now that the alpha.1 tag has been cut for K8s, we have had emulated version added for 3 releases. Add tests for that use case as the KEP states that we should be able to support up to N-3 version skew for emulated versions.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jul 01 '25 20:07 k8s-ci-robot