test-infra icon indicating copy to clipboard operation
test-infra copied to clipboard

kubekins-e2e-v2 multiarch support for s390x

Open prabhav-thali opened this issue 8 months ago • 10 comments

Fixes #34646

Had to skip below utilities for s390x: gcloud core install google-cloud-sdk/install.sh kind

prabhav-thali avatar Apr 07 '25 10:04 prabhav-thali

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: prabhav-thali / name: Prabhav Thali (6280040e9fe79f4c21462d8dea59afacf7ff1802)

Welcome @prabhav-thali!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Apr 07 '25 10:04 k8s-ci-robot

Hi @prabhav-thali. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Apr 07 '25 10:04 k8s-ci-robot

/hold

we should not be doing this piecemeal, please talk to the ppc64le folks and figure out a comprehensive strategy including CI/CD

dims avatar Apr 07 '25 12:04 dims

xref: https://github.com/kubernetes/kubernetes/issues/131555

dims avatar May 05 '25 19:05 dims

Hi @dims, We have completed the testing. Umbrella issue has been created, and the status of items has been updated. Could you please review the PR?

prabhav-thali avatar Jun 16 '25 11:06 prabhav-thali

/assign @BenTheElder

dims avatar Jun 16 '25 13:06 dims

/cc @upodroid

BenTheElder avatar Jun 17 '25 01:06 BenTheElder

looks OK to me, this image is something upodroid started, so looking for their ACK /ok-to-test

BenTheElder avatar Jun 17 '25 01:06 BenTheElder

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prabhav-thali, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jun 17 '25 08:06 k8s-ci-robot

/hold cancel

upodroid avatar Jul 22 '25 06:07 upodroid