test-infra icon indicating copy to clipboard operation
test-infra copied to clipboard

Don't use imagePullPolicy: Always on prow jobs

Open aojea opened this issue 1 year ago • 5 comments

          Which was from me then. But I, too, must have copied it from somewhere else.

Probably pull-kubernetes-verify: https://github.com/kubernetes/test-infra/blob/ab1dea0a2d9bb1db98ab80b06fbb7de1fd381585/config/jobs/kubernetes/sig-testing/verify.yaml#L20-L21

There's a ton of other hits when grepping for it: https://github.com/search?q=repo%3Akubernetes%2Ftest-infra%20%22imagePullPolicy%3A%20Always%22&type=code

Originally posted by @pohly in https://github.com/kubernetes/test-infra/pull/33866#discussion_r1861679655

aojea avatar Nov 28 '24 10:11 aojea

Why we want this: imagePullPolicy: Always causes additional overhead when the image has a fixed version and doesn't get updated in the registry. Use it only if the image is a floating reference.

pohly avatar Nov 28 '24 11:11 pohly

We intentionally used it on some jobs that trial the absolutely latest image, but most jobs shouldn't be using it.

BenTheElder avatar Dec 03 '24 21:12 BenTheElder

/sig testing

BenTheElder avatar Dec 03 '24 21:12 BenTheElder

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Mar 03 '25 22:03 k8s-triage-robot

/remove lifecycle-stale /lifecycle frozen

pohly avatar Mar 04 '25 07:03 pohly