test-infra icon indicating copy to clipboard operation
test-infra copied to clipboard

autoscaling: add CA test for build tags

Open jackfrancis opened this issue 1 year ago • 2 comments

Adds a new cluster-autoscaling presubmit to validate go build tags.

Won't work until https://github.com/kubernetes/autoscaler/pull/7391 is merged.

jackfrancis avatar Oct 14 '24 23:10 jackfrancis

/assign @MaciekPytel

jackfrancis avatar Oct 14 '24 23:10 jackfrancis

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 12 '25 23:01 k8s-triage-robot

/remove-lifecycle stale /assign @voelzmo

/hold

until https://github.com/kubernetes/autoscaler/pull/7391 merges

jackfrancis avatar Jan 13 '25 23:01 jackfrancis

/hold cancel

https://github.com/kubernetes/autoscaler/pull/7391 has merged, now we can merge this and start running CI for provider-specific build tags

cc @maciekpytel @bskiba @kwiesmueller @voelzmo

jackfrancis avatar Jan 21 '25 23:01 jackfrancis

/lgtm /approve

voelzmo avatar Mar 10 '25 15:03 voelzmo

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, voelzmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Mar 10 '25 15:03 k8s-ci-robot

@jackfrancis: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-autoscaling-presubmits.yaml using file config/jobs/kubernetes/sig-autoscaling/sig-autoscaling-presubmits.yaml

In response to this:

Adds a new cluster-autoscaling presubmit to validate go build tags.

Won't work until https://github.com/kubernetes/autoscaler/pull/7391 is merged.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Mar 10 '25 15:03 k8s-ci-robot