test-infra
test-infra copied to clipboard
kubernetes
Remove cloud-provider-azure push-images
cloud-controller-manager and cloud-node-manager images are already hosted in MCR. It doesn't seem to be necessary here.
Uh, this is the opposite direction of how we've been trying to setup the project to not depend on infrastructure only members at a single company can access?
can we not do this?
Ideally, if no one at Microsoft is focused on this project at some point, other people can still contribute and step up to maintain it, even for a vendor integration project. That's more difficult if we have dependencies on accounts that aren't provided by the project in areas like test and releasing.
I have to echo what @BenTheElder said. All projects living under the Kubernetes umbrella, i.e. in the Kubernetes GitHub organizations, should use the community infrastructure for their purposes, unless instructed otherwise by SIG K8s Infra. We did some very hard job to migrate away from the company-specific infrastructure that we have zero access to and zero insights into, let's not go backwards again.
We very welcome projects and companies to mirror images to their registries and use those mirrored images for their platforms/products/customers, but the authoritative source should always be hosted on the community infrastructure.
Also, let's not forget the situation that we had with vSphere-related projects just a couple of weeks ago, where the registry simply went missing: https://github.com/kubernetes-sigs/vsphere-csi-driver/issues/3053
We want to make sure that we can avoid such situations, and the only way we can do that is by ensuring we have (some) control over the infrastructure.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: lzhecheng, timwangmusic
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~config/jobs/image-pushing/OWNERS~~ [timwangmusic]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hello @timwangmusic , I saw other owners are talking about that such images should be managed by community. Do you reach an agreement on deletion? Because @dims is still holding this PR.
Hello @timwangmusic , I saw other owners are talking about that such images should be managed by community. Do you reach an agreement on deletion? Because @dims is still holding this PR.
Read the comments and I concur with the other owners on holding the PR.
@lzhecheng: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-test-infra-verify-lint | 7c5b1b2723a6f51991ffd97727fba5ddc538a939 | link | true | /test pull-test-infra-verify-lint |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@feiskyer: Closed this PR.
In response to this:
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.