test-infra icon indicating copy to clipboard operation
test-infra copied to clipboard
verified publisher icon kubernetes

etcd: Add golvuncheck for 3.4, 3.5

Open ArkaSaha30 opened this issue 1 year ago • 8 comments

This commit will run pull-etcd-govulncheck for release-3.4, release-3.5 branch in addition to main. Issue link: https://github.com/kubernetes/test-infra/issues/32754

cc @ivanvc

ArkaSaha30 avatar Jun 20 '24 18:06 ArkaSaha30

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ArkaSaha30 Once this PR has been reviewed and has the lgtm label, please assign jmhbnz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jun 20 '24 18:06 k8s-ci-robot

@jmhbnz, do we want to migrate jobs from branches other than main to prow? I haven't opened pull requests that run for 3.4/3.5 mainly because the Makefiles as stated above, are not always 100% compatible, and also because I haven't seen an effort to migrate these two branches.

ivanvc avatar Jun 21 '24 03:06 ivanvc

@jmhbnz, do we want to migrate jobs from branches other than main to prow? I haven't opened pull requests that run for 3.4/3.5 mainly because the Makefiles as stated above, are not always 100% compatible, and also because I haven't seen an effort to migrate these two branches.

Good question - We could discuss at community meeting potentially or cc @ahrtr and @serathius for async decision. Personally I would be in favor.

jmhbnz avatar Jun 21 '24 04:06 jmhbnz

do we want to migrate jobs from branches other than main to prow?

I do not see a reason not to do it. So yes to me.

ahrtr avatar Jun 21 '24 05:06 ahrtr

Link to etcd-io/etcd#18173.

Regardless of the previous comment and outcome. I think we're ready to drop the optional: true and tune the requested CPU/memory. I was going to do it in a separate pull request, but I think it's fine if you update the values. The CPU should be at 4, and we can lower the memory to 1Gi, based on one week's usage (Grafana).

ivanvc avatar Jun 21 '24 15:06 ivanvc

We discussed this issue at the August 1st's etcd triage meeting. I'm just bumping this with a comment so we don't forget.

@ArkaSaha30, do you have the capacity to do the backports?

ivanvc avatar Aug 07 '24 23:08 ivanvc

We discussed this issue at the August 1st's etcd triage meeting. I'm just bumping this with a comment so we don't forget.

@ArkaSaha30, do you have the capacity to do the backports?

Yess @ivanvc, I plan to take it up today or tomorrow. Slightly tied up with downstream work.

ArkaSaha30 avatar Aug 08 '24 05:08 ArkaSaha30

No worries, @ArkaSaha30. No rush at all. I was making sure that we didn't forget about this open issue.

ivanvc avatar Aug 08 '24 18:08 ivanvc

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Nov 06 '24 18:11 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Dec 06 '24 19:12 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar Jan 05 '25 20:01 k8s-triage-robot

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jan 05 '25 20:01 k8s-ci-robot