test-infra icon indicating copy to clipboard operation
test-infra copied to clipboard

CAPO: add apidiff optional job

Open EmilienM opened this issue 1 year ago • 9 comments

Add a new job to run apidiff on CAPO main PRs.

TODO:

  • [ ] Get https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/2096

EmilienM avatar May 22 '24 16:05 EmilienM

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: EmilienM Once this PR has been reviewed and has the lgtm label, please assign fabriziopandini for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 22 '24 16:05 k8s-ci-robot

We need https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/2096 first.

EmilienM avatar May 22 '24 16:05 EmilienM

/cc mdbooth lentzi90

EmilienM avatar May 22 '24 16:05 EmilienM

Related to https://github.com/kubernetes-sigs/cluster-api-provider-openstack/issues/1860

EmilienM avatar May 22 '24 16:05 EmilienM

/hold for dependency to land once we figure out how we want to run it.

EmilienM avatar May 22 '24 16:05 EmilienM

We need kubernetes-sigs/cluster-api-provider-openstack#2096 first.

Can you put this dependency in the description as a TODO item?

mdbooth avatar May 23 '24 10:05 mdbooth

/hold cancel

EmilienM avatar Jun 10 '24 20:06 EmilienM

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Sep 08 '24 21:09 k8s-triage-robot

/remove-lifecycle stale

EmilienM avatar Sep 09 '24 11:09 EmilienM

I'll re-open this one when we'll want to have it. For now we don't have the desire of gating apidiff.

EmilienM avatar Dec 02 '24 17:12 EmilienM

/close

EmilienM avatar Dec 02 '24 17:12 EmilienM

@EmilienM: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Dec 02 '24 17:12 k8s-ci-robot