test-infra icon indicating copy to clipboard operation
test-infra copied to clipboard

Assign/CC doesn't work when there is trailing text

Open dprotaso opened this issue 1 year ago • 2 comments

I added a comment at the end of my assign command and oddly it didn't work

https://github.com/kubernetes-sigs/gateway-api/pull/2845#issuecomment-1984579155

/assign @some-user #...

I'd assume it would assign the issue to some-user - unsure if the regexp is too strict or not

dprotaso avatar Mar 07 '24 22:03 dprotaso

/sig testing

dprotaso avatar Mar 07 '24 22:03 dprotaso

this is true of most prow commands I think? you generally need to move non-command input to another line

BenTheElder avatar Mar 13 '24 22:03 BenTheElder

That's fair - I guess assign works without the @ so it wouldn't know if a normal word is a comment or a user

dprotaso avatar Apr 01 '24 20:04 dprotaso