test-infra icon indicating copy to clipboard operation
test-infra copied to clipboard

Disable VAP test from alpha/beta since it is GA

Open cici37 opened this issue 1 year ago • 7 comments

ValidatingAdmissionPolicy is graduated to GA in 1.30 and the feature gate is turned on by default, hence we will disable the test from alpha/beta. The same e2e tests are enabled in presubmit job through https://github.com/kubernetes/kubernetes/pull/123774. Thanks!

cici37 avatar Mar 06 '24 19:03 cici37

/hold til https://github.com/kubernetes/kubernetes/pull/123774 merged first.

cici37 avatar Mar 06 '24 19:03 cici37

/unhold /assign @cheftako @andrewsykim for approval when you have time :)

cici37 avatar Mar 07 '24 18:03 cici37

/assign @jiahuif for review. Thanks!

cici37 avatar Mar 14 '24 17:03 cici37

/lgtm /assign @cheftako @andrewsykim

jiahuif avatar Mar 14 '24 18:03 jiahuif

/retest

cici37 avatar Mar 28 '24 17:03 cici37

/lgtm /approve

cheftako avatar May 01 '24 17:05 cheftako

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, cici37

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 01 '24 17:05 k8s-ci-robot

@cici37: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key gcp-gce.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml
  • key periodic-e2e.yaml using file config/jobs/kubernetes/sig-cloud-provider/periodic-e2e.yaml

In response to this:

ValidatingAdmissionPolicy is graduated to GA in 1.30 and the feature gate is turned on by default, hence we will disable the test from alpha/beta. The same e2e tests are enabled in presubmit job through https://github.com/kubernetes/kubernetes/pull/123774. Thanks!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar May 01 '24 17:05 k8s-ci-robot