test-infra icon indicating copy to clipboard operation
test-infra copied to clipboard

Remove containerd deprecated registry options

Open adisky opened this issue 1 year ago • 8 comments

remove containerd deprecated registry configs

update plugins."io.containerd.grpc.v1.cri".registry.mirrors-->plugins.'"io.containerd.grpc.v1.cri'".registry config_path

ref: https://github.com/containerd/containerd/pull/9766

adisky avatar Feb 07 '24 14:02 adisky

/hold will create a new containerd 2.0 config and test it for one job , then update the currently used config which is used by many jobs to have minimal impact in case something fails

adisky avatar Feb 07 '24 14:02 adisky

/assign @ruiwen-zhao

ndixita avatar Feb 07 '24 18:02 ndixita

https://github.com/kubernetes/test-infra/issues/31851

BenTheElder avatar Feb 08 '24 22:02 BenTheElder

Migrating single job to use containerd config_path https://github.com/kubernetes/test-infra/pull/31954/

adisky avatar Feb 12 '24 05:02 adisky

What's the current status?

AkihiroSuda avatar Feb 28 '24 00:02 AkihiroSuda

we have migrated one job and it is running fine https://github.com/kubernetes/test-infra/pull/31954 https://github.com/kubernetes/test-infra/pull/31970

adisky avatar Feb 29 '24 06:02 adisky

cc @SergeyKanzhelev

adisky avatar Mar 11 '24 06:03 adisky

@samuelkarp: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 30 '24 17:04 k8s-ci-robot

@ruiwen-zhao @SergeyKanzhelev Updated

adisky avatar May 03 '24 03:05 adisky

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adisky, ruiwen-zhao, samuelkarp, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 06 '24 18:05 k8s-ci-robot

/unhold

SergeyKanzhelev avatar May 07 '24 19:05 SergeyKanzhelev