test-infra icon indicating copy to clipboard operation
test-infra copied to clipboard

Migrate remaining `sig-node` jobs to community clusters

Open rjsadow opened this issue 1 year ago • 15 comments

The following jobs still run on the default google owned cluster and need to be migrated to a community cluster

node-problem-detector

containerd

rjsadow avatar Feb 01 '24 12:02 rjsadow

/sig testing /sig k8s-infra /sig node

rjsadow avatar Feb 01 '24 12:02 rjsadow

/help wanted /good-first-issue

kannon92 avatar Feb 08 '24 01:02 kannon92

@kannon92: This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to this:

/help wanted /good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Feb 08 '24 01:02 k8s-ci-robot

Hey @rjsadow and @kannon92 I would like to work on this

Bharadwajshivam28 avatar Feb 08 '24 23:02 Bharadwajshivam28

/assign I can work on node-problem-detector @Bharadwajshivam28 would you like to work on the containerd jobs?

SD-13 avatar Feb 09 '24 11:02 SD-13

/assign I can work on node-problem-detector @Bharadwajshivam28 would you like to work on the containerd jobs?

Ya works for me 😀

Bharadwajshivam28 avatar Feb 09 '24 13:02 Bharadwajshivam28

/assign

Working on containerd one

Bharadwajshivam28 avatar Feb 09 '24 13:02 Bharadwajshivam28

@rjsadow FYI, node-problem-detector is migrated in this issue https://github.com/kubernetes/kubernetes/issues/119211

SD-13 avatar Mar 11 '24 15:03 SD-13

@Bharadwajshivam28 Are you working to migrate containerd jobs? If not, I can help with that.

SD-13 avatar Mar 11 '24 15:03 SD-13

I tried to migrate the NPD tests but still saw the 403 Forbidden error. I am not sure why the same tests can work in CI, but not in presubmits, or vice versa. My PRs have been reverted. @SD-13 if you have time to investigate more, it would be really appreciated.

wangzhen127 avatar Mar 11 '24 16:03 wangzhen127

@Bharadwajshivam28 Are you working to migrate containerd jobs? If not, I can help with that.

Hey you can go ahead with it

Bharadwajshivam28 avatar Mar 11 '24 20:03 Bharadwajshivam28

/unassign @Bharadwajshivam28

SD-13 avatar Mar 12 '24 08:03 SD-13

@wangzhen127 I will dig into this issue!

ERROR: failed to solve: failed to push gcr.io/node-problem-detector-staging/ci/node-problem-detector:v0.8.16-14-gb48e438-20240311.1409: failed to authorize: failed to fetch oauth token: unexpected status from GET request to https://gcr.io/v2/token?scope=repository%3Anode-problem-detector-staging%2Fci%2Fnode-problem-detector%3Apull%2Cpush&service=gcr.io: 403 Forbidden

Will start from these logs. Initially seems like, it didn't have necessary permissions or a good credential...

SD-13 avatar Mar 12 '24 08:03 SD-13

https://github.com/kubernetes/test-infra/pull/32261#issuecomment-1997960257

@ameukam do we have those documented anywhere? (if yes and they're solvable, point me in the right direction and i'll take a look in the next couple of weeks)

endocrimes avatar Apr 25 '24 21:04 endocrimes