kubernetes
deck: fix reading loglines from S3 buckets
The EOF error for Storage Artifacts can be wrapped via fmt.Errorf("error reading from artifact: %w", err), which broke this error check. The effect is that when using S3 with Prow, clicking on "NNN skipped lines…" on a Spyglass page resulted in
Failed to retrieve log lines: couldn't read requested bytes: error reading from artifact: EOF
The "show all hidden lines" function was not affected by this bug.
The same bug did not occur in another Prow setup where GCS is used, so I presume it's related to that?
Hi @xrstf. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: petr-muller, xrstf
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~prow/spyglass/OWNERS~~ [petr-muller]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/test pull-test-infra-integration /lgtm cancel
--- FAIL: TestDeckTenantIDs/public-deck
@xrstf: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-test-infra-integration | cb5ecf58f3c9e3379c27eae0750a45499eb8e7e5 | link | true | /test pull-test-infra-integration |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Hello @xrstf, the Prow source code has been moved to https://github.com/kubernetes-sigs/prow on April 9, 2024. Please consider migrate this PR (by opening a new one in there). Thanks!
