test-infra icon indicating copy to clipboard operation
test-infra copied to clipboard

Allow running e2e tests as presubmits on GitHub

Open uroy-personal opened this issue 2 years ago • 19 comments

uroy-personal avatar Oct 10 '23 02:10 uroy-personal

Hi @uroy-personal. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 10 '23 02:10 k8s-ci-robot

For the issue : https://github.com/kubernetes/autoscaler/issues/5918

uroy-personal avatar Oct 10 '23 02:10 uroy-personal

Good Morning @jbartosik , @kgolab , @pbetkier , @mwielgus & @bskiba.

I had to close the PR : https://github.com/kubernetes/test-infra/pull/30927 as my fork got lots of conflicts while rebasing the changes from parent repository. I recreated the fork again and raised this fresh PR.

Please help with approvals for this PR. Thanks a lot.

uroy-personal avatar Oct 10 '23 02:10 uroy-personal

/retest

uroy-personal avatar Oct 10 '23 02:10 uroy-personal

@uroy-personal: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 10 '23 02:10 k8s-ci-robot

/ok-to-test /lgtm

kwiesmueller avatar Oct 11 '23 13:10 kwiesmueller

/retest

uroy-personal avatar Oct 12 '23 11:10 uroy-personal

/lgtm

uroy-personal avatar Oct 12 '23 13:10 uroy-personal

@uroy-personal: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 12 '23 13:10 k8s-ci-robot

Good Morning @kwiesmueller , All clear for this PR. Please help with approval. Thanks.

uroy-personal avatar Oct 12 '23 13:10 uroy-personal

/assign @maciekpytel

kwiesmueller avatar Oct 12 '23 14:10 kwiesmueller

/lgtm as well.

cc @jbartosik

laoj2 avatar Oct 17 '23 20:10 laoj2

@mwielgus please take a look

jbartosik avatar Oct 18 '23 07:10 jbartosik

@laoj2: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 18 '23 13:10 k8s-ci-robot

Good Morning @mwielgus, Could you please help with review. Thanks in advace.

uroy-personal avatar Nov 15 '23 02:11 uroy-personal

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Feb 13 '24 03:02 k8s-triage-robot

Hi @kwiesmueller , Is this PR still relevant? Please advise if it could be merged.

uroy-personal avatar Feb 21 '24 02:02 uroy-personal

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Mar 22 '24 03:03 k8s-triage-robot

/remove-lifecycle rotten

voelzmo avatar Apr 02 '24 08:04 voelzmo

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbartosik, laoj2, mwielgus, uroy-personal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Apr 08 '24 14:04 k8s-ci-robot

@uroy-personal: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-autoscaling-presubmits.yaml using file config/jobs/kubernetes/sig-autoscaling/sig-autoscaling-presubmits.yaml

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 08 '24 14:04 k8s-ci-robot