test-infra icon indicating copy to clipboard operation
test-infra copied to clipboard

[wip] bump controller-runtime and all other deps

Open upodroid opened this issue 2 years ago • 6 comments

Boskos errors, xref https://github.com/kubernetes-sigs/boskos/pull/173

 mahamed  REDACTED  ~  Desktop  Git  boskos   remove-pw-from-client  3✎  $  make build
MINIMUM_GO_VERSION=go1.19.12 ./hack/ensure-go.sh
go build ./...
# k8s.io/test-infra/prow/flagutil
../../../go/pkg/mod/k8s.io/[email protected]/prow/flagutil/kubernetes_cluster_clients.go:364:3: unknown field MetricsBindAddress in struct literal of type "sigs.k8s.io/controller-runtime/pkg/manager".Options
../../../go/pkg/mod/k8s.io/[email protected]/prow/flagutil/kubernetes_cluster_clients.go:365:3: unknown field DryRunClient in struct literal of type "sigs.k8s.io/controller-runtime/pkg/manager".Options
../../../go/pkg/mod/k8s.io/[email protected]/prow/flagutil/kubernetes_cluster_clients.go:394:50: options.Namespace undefined (type "sigs.k8s.io/controller-runtime/pkg/manager".Options has no field or method Namespace)
../../../go/pkg/mod/k8s.io/[email protected]/prow/flagutil/kubernetes_cluster_clients.go:430:64: options.Namespace undefined (type "sigs.k8s.io/controller-runtime/pkg/manager".Options has no field or method Namespace)
make: *** [build] Error 1

This library hasn't been updated for a long time and the devs introduced plenty of breaking changes.

upodroid avatar Oct 08 '23 21:10 upodroid

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: upodroid Once this PR has been reviewed and has the lgtm label, please assign cjwagner for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Oct 08 '23 21:10 k8s-ci-robot

/cc @alvaroaleman

upodroid avatar Oct 08 '23 21:10 upodroid

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Nov 15 '23 15:11 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Feb 13 '24 15:02 k8s-triage-robot

/uncc

alvaroaleman avatar Mar 13 '24 20:03 alvaroaleman

@upodroid: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-test-infra-integration b20493f34277fe1c6586647079fc910f761d95fb link true /test pull-test-infra-integration
pull-test-infra-unit-test b20493f34277fe1c6586647079fc910f761d95fb link true /test pull-test-infra-unit-test
pull-test-infra-prow-image-build-test b20493f34277fe1c6586647079fc910f761d95fb link true /test pull-test-infra-prow-image-build-test
pull-test-infra-unit-test-race-detector-nonblocking b20493f34277fe1c6586647079fc910f761d95fb link false /test pull-test-infra-unit-test-race-detector-nonblocking
pull-test-infra-verify-lint b20493f34277fe1c6586647079fc910f761d95fb link true /test pull-test-infra-verify-lint
pull-test-infra-misc-image-build-test b20493f34277fe1c6586647079fc910f761d95fb link true /test pull-test-infra-misc-image-build-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot avatar Apr 09 '24 22:04 k8s-ci-robot

Closing as prow moved to its own repo

upodroid avatar Apr 11 '24 15:04 upodroid