test-infra icon indicating copy to clipboard operation
test-infra copied to clipboard

k8s-ci-robot cannot correctly remove the label related to the deleted code

Open rayowang opened this issue 2 years ago • 4 comments

What happened: It may be that I used git rebase improperly, which led to the introduction of a large number of new commits in my PR. At this time, k8s-ci-robot added a lot of labels related to these commit codes, but when I removed these incorrect commits Afterwards, k8s-ci-robot did not remove the related label.

What you expected to happen:

After removing the commit related to the labeled label, the previously labeled label should also be removed.

How to reproduce it (as minimally and precisely as possible):

Please provide links to example occurrences, if any: https://github.com/kubernetes/kubernetes/pull/118636

Anything else we need to know?:

rayowang avatar Jun 19 '23 03:06 rayowang

/help

rayowang avatar Jun 28 '23 17:06 rayowang

@rayowang: This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jun 28 '23 17:06 k8s-ci-robot

/sig testing

palnabarun avatar Oct 06 '23 07:10 palnabarun

/assign

sayanchowdhury avatar Oct 06 '23 07:10 sayanchowdhury

This is not simple, because we have to make sure the label wasn't added by something else, e.g. a human requesting the label be added

BenTheElder avatar Jul 17 '24 23:07 BenTheElder

In any case, the code for this is now in a dedicated repo, if you're still interested in attempting to figure out how this could be done, please file an issue at https://github.com/kubernetes-sigs/prow

BenTheElder avatar Jul 17 '24 23:07 BenTheElder