test-infra icon indicating copy to clipboard operation
test-infra copied to clipboard
verified publisher icon kubernetes

cherrypick plugin doesn't response to all commands in a github comment

Open dprotaso opened this issue 2 years ago • 4 comments

What happened: cherry-pick plugin didn't detect multiple uses of /cherry-pick command in the same message

ie. from https://github.com/knative/serving/pull/14028#issuecomment-1572058940

/cherry-pick release-1.10
/cherry-pick release-1.9

What you expected to happen: It would create two cherry pick PRs

How to reproduce it (as minimally and precisely as possible):

Please provide links to example occurrences, if any:

Anything else we need to know?:

This was fixed but seems to have regressed https://github.com/kubernetes/test-infra/issues/21684 https://github.com/kubernetes/test-infra/issues/21714

Knative is using

      - name: cherrypicker
        image: gcr.io/k8s-prow/cherrypicker:v20230526-bc91fd978b

From: https://github.com/knative/infra/blob/main/prow/cluster/control-plane/500-cherrypicker.yaml

dprotaso avatar Jun 01 '23 14:06 dprotaso

/sig testing

dprotaso avatar Jun 01 '23 14:06 dprotaso

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 21 '24 17:01 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Feb 20 '24 17:02 k8s-triage-robot

/lifecycle frozen

dprotaso avatar Feb 20 '24 17:02 dprotaso

cherrypick is now at https://github.com/kubernetes-sigs/prow/tree/main/cmd/external-plugins/cherrypicker

unfortunately github cannot move issues across repos, but if you're still interested, please re-file against the prow issue tracker, I'm working on closing out prow issues here

BenTheElder avatar Jul 17 '24 23:07 BenTheElder