test-infra icon indicating copy to clipboard operation
test-infra copied to clipboard

Replace cleartext creds to secrets in sample manifests

Open sarab97 opened this issue 2 years ago • 7 comments

Fixes #29455

sarab97 avatar May 13 '23 13:05 sarab97

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sarab97 Once this PR has been reviewed and has the lgtm label, please assign chaodaig for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 13 '23 13:05 k8s-ci-robot

@dims @sarab97 hi, still planning on merging this?

Note also https://github.com/kubernetes/test-infra/pull/29935

MaxHorstmann avatar Aug 04 '23 17:08 MaxHorstmann

oh yes @MaxHorstmann. Still waiting on reply from @dims. I followed the currently implemented approach. However the PR you linked does suggest better approach Im open to work to implement that here as well. @dims can you comment?

sarab97 avatar Aug 19 '23 01:08 sarab97

@sarab97 thanks for your response! fyi #29935 now merged.

MaxHorstmann avatar Aug 23 '23 17:08 MaxHorstmann

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 21 '24 04:01 k8s-triage-robot