test-infra
test-infra copied to clipboard
Replace cleartext creds to secrets in sample manifests
Fixes #29455
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: sarab97 Once this PR has been reviewed and has the lgtm label, please assign chaodaig for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@dims @sarab97 hi, still planning on merging this?
Note also https://github.com/kubernetes/test-infra/pull/29935
oh yes @MaxHorstmann. Still waiting on reply from @dims. I followed the currently implemented approach. However the PR you linked does suggest better approach Im open to work to implement that here as well. @dims can you comment?
@sarab97 thanks for your response! fyi #29935 now merged.
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale