test-infra icon indicating copy to clipboard operation
test-infra copied to clipboard

Update trusted author handling for DCO

Open dhaiducek opened this issue 1 year ago • 8 comments

  • Separate member and collaborator configurations (since these are separate booleans, it makes more sense to handle them separately rather than tie them together)
  • Separate trusted apps from the member and collaborator handling (originally trusted apps couldn't be specified unless one of the skip booleans was set. This doesn't make a whole lot of sense since a trusted app is neither of those.)

dhaiducek avatar Apr 06 '23 20:04 dhaiducek

Hi @dhaiducek. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 06 '23 20:04 k8s-ci-robot

/ok-to-test

petr-muller avatar Apr 26 '23 16:04 petr-muller

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 18 '24 23:01 k8s-triage-robot

/remove-lifecycle stale

dhaiducek avatar Jan 19 '24 01:01 dhaiducek

/test all

petr-muller avatar Feb 04 '24 12:02 petr-muller

/lgtm

petr-muller avatar Feb 04 '24 12:02 petr-muller

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dhaiducek Once this PR has been reviewed and has the lgtm label, please ask for approval from petr-muller. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Feb 05 '24 21:02 k8s-ci-robot

/lgtm /test all

petr-muller avatar Mar 15 '24 16:03 petr-muller

@dhaiducek: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-test-infra-misc-image-build-test 5e934cb9ef3b8586868ea390853e564c7700ac04 link true /test pull-test-infra-misc-image-build-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot avatar Apr 09 '24 23:04 k8s-ci-robot

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 10 '24 03:04 k8s-ci-robot

Migrated PR to new repo:

  • https://github.com/kubernetes-sigs/prow/pull/102

dhaiducek avatar Apr 11 '24 17:04 dhaiducek