test-infra icon indicating copy to clipboard operation
test-infra copied to clipboard
verified publisher icon kubernetes

WIP adds IsGitHubAction to ClientOptions

Open RobertKielty opened this issue 3 years ago • 1 comments

When instantiated with IsGitHubAction set to true in ClientOptions the client uses that knowledge to avoid making calls to the /user endpoint on the GitHub API.

The ephemeral token assigned to GitHub Actions when run is not granted the permissions to read /user on the Github API.

Not being able to make this call does not seem to adversely affect prow plugins launched by pga, though fake User and Login are assigned to make the the client behave similarly to the OAuth mechanism as the client makes use of these in the UserGenerator.

Implements #27684

RobertKielty avatar Oct 06 '22 08:10 RobertKielty

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RobertKielty Once this PR has been reviewed and has the lgtm label, please assign stevekuznetsov for approval by writing /assign @stevekuznetsov in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Oct 06 '22 08:10 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 23 '23 16:01 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Mar 17 '23 17:03 k8s-triage-robot

Closing as there is no sponsor or strong community demand for this work to continue, could look at this again should circumstances change.

RobertKielty avatar Mar 21 '23 10:03 RobertKielty