test-infra
test-infra copied to clipboard
kubernetes
Replace `ListTeamMembers` with `ListTeamMembersBySlug`
What should be cleaned up or changed:
ListTeamMembers should be replaced with ListTeamMembersBySlug everywhere
Provide any links for context:
-
ListTeamMembersis deprecated according to https://github.blog/changelog/2022-02-22-sunset-notice-deprecated-teams-api-endpoints/
Extra info:
Search the codebase and look for usage of ListTeamMembersBySlug as examples
/help /good-first-issue
@chaodaiG: This request has been marked as suitable for new contributors.
Guidelines
Please ensure that the issue body includes answers to the following questions:
- Why are we solving this issue?
- To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
- Does this issue have zero to low barrier of entry?
- How can the assignee reach out to you for help?
For more details on the requirements of such an issue, please see here and ensure that they are met.
If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.
In response to this:
What should be cleaned up or changed:
ListTeamMembersshould be replaced withListTeamMembersBySlugeverywhereProvide any links for context:
ListTeamMembersis deprecated according to https://github.blog/changelog/2022-02-22-sunset-notice-deprecated-teams-api-endpoints/Extra info:
Search the codebase and look for usage of
ListTeamMembersBySlugas examples/help /good-first-issue
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@chaodaiG do we have tests to make sure all the things have been done correctly? Or is it manual
@chaodaiG do we have tests to make sure all the things have been done correctly? Or is it manual
There is no e2e test against real GitHub if that's what you ask for. There should be unit tests covering to certain extent
Hey one more question: There are 2 test failures before I started changes so not sure do we need to address that or not.
✓ config/prow/cluster/build/boskos-resources (13ms)
✓ config/tests/lint (83ms)
✓ config/tests/mergelists (23ms)
✓ config/tests/jobs (1.972s)
✓ experiment/bumpmonitoring (19ms)
✓ experiment/ci-janitor (109ms)
✓ experiment/dummybenchmarks (27ms)
✓ experiment/dummybenchmarks/subpkg (10ms)
✓ experiment/coverage (33ms)
✓ experiment/image-bumper/bumper (30ms)
✓ experiment/gerrit-onboarder (43ms)
✓ experiment/logviewer/gcsreader (19ms)
✓ config/tests/testgrids (4.973s)
∅ def/configmap (6ms)
∅ experiment/aws-stockout
∅ experiment/cifuzz_test
∅ experiment/cluster-upgrader
∅ experiment/clustersecretbackup
∅ experiment/clustersecretbackup/secretmanager
∅ experiment/image-bumper
∅ experiment/manual-trigger
∅ experiment/ml/analyze
∅ experiment/ml/prowlog
∅ experiment/ml/prowlog/csv
∅ experiment/prowjob-report
∅ experiment/service-account-creator
∅ experiment/slack-oncall-updater
∅ experiment/update-hook
✓ gcsweb/cmd/gcsweb (291ms)
∅ gcsweb/pkg/version
∅ gencred
✓ gencred/cmd/gencred (45ms)
✓ ghproxy/apptokenequalizer (12ms)
✓ gencred/pkg/serviceaccount (26ms)
✓ ghproxy (47ms)
✓ ghproxy/ghmetrics (28ms)
✓ gopherage/cmd/metadata (6ms)
✓ gopherage/pkg/cov (8ms)
✓ gopherage/pkg/cov/junit/calculation (4ms)
✓ greenhouse/diskcache (25ms)
✓ hack/gen-prow-documented (77ms)
✓ gencred/pkg/certificate (4.027s)
∅ gencred/pkg/kubeconfig
∅ gencred/pkg/secretmanager
∅ gencred/pkg/util
✓ ghproxy/ghcache (6.042s)
∅ gopherage
∅ gopherage/cmd/aggregate
∅ gopherage/cmd/diff
∅ gopherage/cmd/filter
∅ gopherage/cmd/html
∅ gopherage/cmd/junit
∅ gopherage/cmd/merge
∅ gopherage/pkg/cov/junit
∅ gopherage/pkg/util
∅ greenhouse
∅ greenhouse/diskutil
∅ hack/boilerplate/test
✓ kubetest/util (9ms)
✓ kubetest/process (2.417s)
✓ kubetest (194ms)
✓ label_sync (47ms)
✓ maintenance/migratestatus/migrator (13ms)
✓ pkg/genyaml (16ms)
✓ maintenance/migratestatus (75ms)
✓ prow/apis/prowjobs/v1 (151ms)
✓ pkg/ghclient (32ms)
✓ prow/cache (21ms)
✓ prow/bugzilla (81ms)
✓ prow/clonerefs (1.76s)
✓ prow/cmd/admission (95ms)
✓ pkg/benchmarkjunit (13.237s)
✓ prow/cmd/branchprotector (295ms)
✓ hack/prowimagebuilder (48.456s)
∅ hack/ts-rollup
∅ images/builder
∅ kubetest/boskos/client
∅ kubetest/boskos/common
∅ kubetest/boskos/storage
∅ kubetest/conformance
∅ kubetest/e2e
∅ kubetest/kind
∅ linkcheck
∅ logexporter/cmd
∅ pkg/flagutil
∅ prow/apis/prowjobs
∅ prow/client/clientset/versioned
∅ prow/client/clientset/versioned/fake
∅ prow/client/clientset/versioned/scheme
∅ prow/client/clientset/versioned/typed/prowjobs/v1
∅ prow/client/clientset/versioned/typed/prowjobs/v1/fake
∅ prow/client/informers/externalversions
∅ prow/client/informers/externalversions/internalinterfaces
∅ prow/client/informers/externalversions/prowjobs
∅ prow/client/informers/externalversions/prowjobs/v1
∅ prow/client/listers/prowjobs/v1
✓ prow/cmd/checkconfig (167ms)
∅ prow/cmd/clonerefs
✓ prow/cmd/cm2kc (69ms)
✓ prow/cmd/config-bootstrapper (588ms)
✓ prow/cmd/crier (115ms)
✖ prow/cmd/entrypoint (7ms)
✓ prow/cmd/generic-autobumper (46ms)
✓ prow/cmd/generic-autobumper/bumper (32ms)
✓ prow/cmd/exporter (120ms)
✓ prow/cmd/deck (187ms)
∅ prow/cmd/gcsupload
✓ prow/cmd/gerrit (63ms)
∅ prow/cmd/grandmatriarch
✓ prow/cmd/hmac (68ms)
∅ prow/cmd/hmac/fakeghhook
✓ prow/cmd/horologium (80ms)
✓ prow/cmd/invitations-accepter (54ms)
✓ prow/cmd/hook (130ms)
∅ prow/cmd/initupload
✓ prow/cmd/jenkins-operator (111ms)
✓ prow/cmd/mkpj (69ms)
✓ prow/cmd/mkpod (80ms)
✓ prow/cmd/phaino (50ms)
✓ prow/cmd/peribolos (144ms)
∅ prow/cmd/phony
✓ prow/cmd/pipeline (112ms)
∅ prow/cmd/prow-controller-manager
∅ prow/cmd/sidecar
✓ prow/cmd/sinker (78ms)
✓ prow/cmd/status-reconciler (79ms)
∅ prow/cmd/sub
∅ prow/cmd/tackle
✓ prow/commentpruner (52ms)
✓ prow/cmd/tot (94ms)
✓ prow/cmd/tide (108ms)
∅ prow/cmd/tot/fallbackcheck
✓ prow/cmd/webhook-server (108ms)
✓ prow/config/org (11ms)
✓ prow/config/jobtests (994ms)
✓ prow/config/secret (2.036s)
✓ prow/crier (289ms)
✓ prow/crier/reporters/criercommonlib (69ms)
✓ prow/crier/reporters/gcs (58ms)
✓ prow/crier/reporters/gcs/kubernetes (98ms)
✓ prow/crier/reporters/gcs/util (87ms)
✓ prow/crier/reporters/github (64ms)
✓ prow/crier/reporters/pubsub (54ms)
✓ prow/crier/reporters/slack (74ms)
✓ prow/cron (79ms)
✓ prow/deck/jobs (84ms)
✓ prow/crier/reporters/gerrit (8.402s)
✓ prow/entrypoint (3.178s)
✓ prow/external-plugins/needs-rebase/plugin (73ms)
✓ prow/external-plugins/cherrypicker (4.438s)
✓ prow/flagutil (121ms)
✓ prow/genfiles (59ms)
✓ prow/gcsupload (157ms)
✓ prow/config (24.248s)
∅ prow/crier/reporters/gcs/kubernetes/api
∅ prow/external-plugins/cherrypicker/lib
∅ prow/external-plugins/needs-rebase
∅ prow/external-plugins/refresh
∅ prow/flagutil/config
∅ prow/flagutil/plugins
✓ prow/gerrit/fakegerrit (15ms)
✓ prow/gerrit/source (22ms)
✓ prow/gerrit/client (193ms)
✓ prow/gerrit/adapter (294ms)
✓ prow/git/v2 (35ms)
✓ prow/ghhook (59ms)
✓ prow/gitattributes (17ms)
✓ prow/github/report (71ms)
✓ prow/git (5.206s)
∅ prow/git/localgit
∅ prow/git/types
✓ prow/github (861ms)
∅ prow/github/fakegithub
✓ prow/githubeventserver (70ms)
✓ prow/googlecloudbuild/client (25ms)
✓ prow/githuboauth (70ms)
∅ prow/googlecloudbuild/client/fake
✓ prow/interrupts (512ms)
✓ prow/initupload (178ms)
✓ prow/io/providers (16ms)
✓ prow/io (64ms)
✓ prow/hook (106ms)
∅ prow/hook/plugin-imports
∅ prow/io/fakeopener
✓ prow/jira (24ms)
✓ prow/jira/fakejira (43ms)
✓ prow/logrusutil (9ms)
✓ prow/kube (66ms)
✓ prow/metrics/prowjobs (42ms)
✓ prow/metrics (101ms)
✓ prow/pjutil (120ms)
✓ prow/jenkins (6.32s)
∅ prow/labels
∅ prow/phony
∅ prow/pipeline/clientset/versioned
∅ prow/pipeline/clientset/versioned/fake
∅ prow/pipeline/clientset/versioned/scheme
∅ prow/pipeline/clientset/versioned/typed/pipeline/v1alpha1
∅ prow/pipeline/clientset/versioned/typed/pipeline/v1alpha1/fake
∅ prow/pipeline/clientset/versioned/typed/pipeline/v1beta1
∅ prow/pipeline/clientset/versioned/typed/pipeline/v1beta1/fake
∅ prow/pipeline/informers/externalversions
∅ prow/pipeline/informers/externalversions/internalinterfaces
∅ prow/pipeline/informers/externalversions/pipeline
∅ prow/pipeline/informers/externalversions/pipeline/v1alpha1
∅ prow/pipeline/informers/externalversions/pipeline/v1beta1
∅ prow/pipeline/listers/pipeline/v1alpha1
∅ prow/pipeline/listers/pipeline/v1beta1
∅ prow/pjutil/pprof
∅ prow/pkg/layeredsets
✓ prow/pluginhelp/hook (1.068s)
✓ prow/plugins/approve/approvers (36ms)
✓ prow/plank (3.064s)
∅ prow/pluginhelp
∅ prow/pluginhelp/externalplugins
✓ prow/plugins/approve (218ms)
✓ prow/plugins/assign (81ms)
✓ prow/plugins/blockade (101ms)
✓ prow/plugins/blunderbuss (109ms)
✓ prow/plugins/branchcleaner (111ms)
✓ prow/plugins/bugzilla (83ms)
✓ prow/plugins/buildifier (599ms)
✓ prow/plugins/cat (108ms)
✓ prow/plugins/cherrypickunapproved (50ms)
✓ prow/plugins/cla (108ms)
✓ prow/plugins/dco (89ms)
✓ prow/plugins/golint/suggestion (46ms)
✓ prow/plugins (16.355s)
✓ prow/plugins/dog (97ms)
✓ prow/plugins/goose (73ms)
✓ prow/plugins/heart (64ms)
✓ prow/plugins/help (57ms)
✓ prow/plugins/hold (52ms)
✓ prow/plugins/invalidcommitmsg (103ms)
✓ prow/plugins/jira (71ms)
✓ prow/plugins/golint (6.764s)
✓ prow/plugins/label (77ms)
✓ prow/plugins/lgtm (90ms)
✓ prow/plugins/lifecycle (80ms)
✓ prow/plugins/merge-method-comment (80ms)
✓ prow/plugins/milestone (83ms)
✓ prow/plugins/milestoneapplier (66ms)
✓ prow/plugins/mergecommitblocker (1.491s)
✓ prow/plugins/milestonestatus (60ms)
✓ prow/plugins/override (78ms)
✓ prow/plugins/owners-label (68ms)
∅ prow/plugins/ownersconfig
✓ prow/plugins/pony (123ms)
✓ prow/plugins/project (96ms)
✓ prow/plugins/projectmanager (134ms)
✓ prow/plugins/releasenote (136ms)
✓ prow/plugins/require-matching-label (72ms)
✓ prow/plugins/retitle (96ms)
✓ prow/plugins/shrug (53ms)
✓ prow/plugins/reward-owners (130ms)
✓ prow/plugins/sigmention (78ms)
✓ prow/plugins/size (79ms)
✓ prow/plugins/skip (58ms)
✓ prow/plugins/slackevents (60ms)
✓ prow/plugins/stage (58ms)
✓ prow/plugins/testfreeze/checker (30ms)
✓ prow/plugins/testfreeze (93ms)
∅ prow/plugins/testfreeze/checker/checkerfakes
∅ prow/plugins/testfreeze/testfreezefakes
✓ prow/plugins/transfer-issue (84ms)
✓ prow/plugins/trigger (88ms)
✓ prow/plugins/trick-or-treat (2.831s)
✓ prow/plugins/welcome (53ms)
✓ prow/plugins/wip (47ms)
✓ prow/plugins/yuks (39ms)
✓ prow/pod-utils/clone (124ms)
✓ prow/pod-utils/downwardapi (69ms)
✓ prow/pod-utils/decorate (73ms)
✓ prow/pod-utils/wrapper (5ms)
✓ prow/plugins/verify-owners (10.835s)
✓ prow/prstatus (43ms)
✓ prow/plugins/updateconfig (13.798s)
✓ prow/pubsub/subscriber (100ms)
✓ prow/secretutil (6ms)
✓ prow/simplifypath (11ms)
✓ prow/slack (6ms)
✓ prow/sidecar (1.444s)
✓ prow/spyglass (166ms)
✓ prow/repoowners (5.315s)
✓ prow/spyglass/lenses (126ms)
✓ prow/spyglass/lenses/buildlog (86ms)
✓ prow/spyglass/lenses/common (83ms)
✓ prow/spyglass/lenses/html (43ms)
✓ prow/spyglass/lenses/junit (83ms)
✓ prow/spyglass/lenses/links (41ms)
✓ prow/spyglass/lenses/metadata (92ms)
✓ prow/spyglass/lenses/podinfo (88ms)
✓ prow/statusreconciler (87ms)
✓ prow/tide/blockers (17ms)
∅ prow/test/integration/test (91ms)
✓ prow/version (11ms)
✓ prow/tide/history (28ms)
✓ releng/config-forker (35ms)
✓ releng/config-rotator (40ms)
✓ robots/coverage/diff (4ms)
✓ robots/issue-creator/creator (8ms)
✓ robots/commenter (48ms)
✓ prow/tide (5.205s)
✓ robots/issue-creator/testowner (21ms)
✓ robots/issue-creator/sources (8ms)
✓ robots/pr-creator/updater (18ms)
✓ prow/pod-utils/gcs (29.093s)
∅ prow/pod-utils/options
∅ prow/spyglass/api
∅ prow/spyglass/lenses/coverage
∅ prow/spyglass/lenses/fake
∅ prow/spyglass/lenses/restcoverage (11ms)
∅ prow/test/integration/cmd/fakegcsserver
∅ prow/test/integration/cmd/fakegerritserver
∅ prow/test/integration/cmd/fakeghserver
∅ prow/test/integration/cmd/fakegitserver
∅ prow/test/integration/cmd/fakepubsub
∅ prow/test/integration/internal/fakegitserver
∅ prow/test/integration/internal/fakepubsub
∅ prow/testutil
∅ robots/coverage
∅ robots/coverage/cmd/diff
∅ robots/coverage/cmd/downloader
∅ robots/coverage/downloader
∅ robots/issue-creator
✓ robots/pr-creator (98ms)
∅ robots/pr-labeler
∅ testgrid/cmd/configurator
∅ testgrid/cmd/transfigure
∅ testgrid/cmd/transfigure/cmd
✓ testgrid/pkg/configurator/options (31ms)
✓ testgrid/pkg/configurator/prow (32ms)
✓ testgrid/pkg/configurator/configurator (3.045s)
=== Skipped
=== SKIP: prow/github TestGetOrg (0.00s)
=== SKIP: prow/plugins/cat TestRealCat (0.00s)
cat_test.go:52: Real cats disabled for automation. Manual users can add --human [--category=foo]
=== SKIP: prow/plugins/dog TestRealDog (0.00s)
dog_test.go:49: Real dogs disabled for automation. Manual users can add --human [--category=foo]
=== SKIP: prow/plugins/goose TestRealGoose (0.00s)
goose_test.go:46: Real geese disabled for automation. Manual users can add --human
=== SKIP: prow/plugins/pony TestRealPony (0.00s)
pony_test.go:59: Real ponies disabled for automation. Manual users can add --human [--category=foo]
=== SKIP: prow/plugins/yuks TestRealJoke (0.00s)
yuks_test.go:43: Real jokes disabled for automation. Manual users can add --human
=== Failed
=== FAIL: prow/cmd/entrypoint TestCopy/another-mode (0.00s)
time="2022-10-04T20:49:29Z" level=info msg="src is /tmp/TestCopy258483963/001/another-mode"
main_test.go:59: File mode mismatch. Want: -rwxr-xr-x, got: -rwxr-xr--
--- FAIL: TestCopy/another-mode (0.00s)
=== FAIL: prow/cmd/entrypoint TestCopy (0.00s)
DONE 10273 tests, 6 skipped, 2 failures in 392.026s
make: *** [Makefile:26: go-unit] Error 1
File mode mismatch. Want: -rwxr-xr-x, got: -rwxr-xr--
feels to be like development environment difference, this is agnostic to this bug. Feel free to file a separate bug and fix it if it bothers you
hey @hrittikhere Are you working with this yet! I was interested to pick a gfi . Thanks
/unassign
Go for it!
On Sat, 15 Oct, 2022, 1:40 am shivam tyagi, @.***> wrote:
hey @hrittikhere https://github.com/hrittikhere Are you working with this yet! I was interested to pick a gfi . Thanks
— Reply to this email directly, view it on GitHub https://github.com/kubernetes/test-infra/issues/27685#issuecomment-1279414179, or unsubscribe https://github.com/notifications/unsubscribe-auth/AP7IOBYTU7MHIYHYAAFTB5DWDG44HANCNFSM6AAAAAAQ43INKA . You are receiving this because you were mentioned.Message ID: @.***>
Watch out for https://github.com/kubernetes/test-infra/issues/25600 that came up the last time we tried to use ListTeamMembersBySlug everywhere.
I was giving my exams for the last week. Starting with this issue :) thanks for the help @smg247
Hey @ShivamTyagi12345 are you still working on it? I'm interested so assign me if you don't, thanks!
@chaodaiG can you please elaborate more? we have functions that are already commented out with deprecated please use ... Do you want to clean up deprecated functions, or something else?
