test-infra icon indicating copy to clipboard operation
test-infra copied to clipboard

Delete unused jobs

Open mmiranda96 opened this issue 2 years ago • 6 comments

What does this PR do?

Delete the following unused jobs listed in https://github.com/kubernetes/kubernetes/issues/111876:

  • ci-containerd-soak-cos-gce
  • ci-cri-containerd-e2e-cos-gce
  • ci-cri-containerd-e2e-cos-gce-flaky
  • ci-cri-containerd-e2e-cos-gce-ingress
  • ci-cri-containerd-e2e-cos-gce-ip-alias
  • ci-cri-containerd-e2e-cos-gce-proto
  • ci-cri-containerd-e2e-cos-gce-reboot
  • ci-cri-containerd-e2e-cos-gce-serial
  • ci-cri-containerd-e2e-cos-gce-slow

Additionally, deleted ci-cri-containerd-e2e-cos-gce-alpha-features definition, since it has been commented for a while and the issue is closed (and it looks related to the existing one).

These jobs are constantly failing, confirmed that not COS nor containerd monitor these Testgrids so we can delete them.

mmiranda96 avatar Sep 27 '22 21:09 mmiranda96

/triage accepted /kind failing-test /priority critical-urgent /cc @bobbypage

mmiranda96 avatar Sep 27 '22 21:09 mmiranda96

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmiranda96 Once this PR has been reviewed and has the lgtm label, please assign ehashman for approval by writing /assign @ehashman in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 27 '22 21:09 k8s-ci-robot

/lgtm

aojea avatar Sep 27 '22 21:09 aojea

New changes are detected. LGTM label has been removed.

k8s-ci-robot avatar Sep 28 '22 16:09 k8s-ci-robot

/retest

mmiranda96 avatar Oct 17 '22 17:10 mmiranda96

@mmiranda96 can you please review if there are alternative fro all jobs being removed? I know for some, but not sure for others.

SergeyKanzhelev avatar Oct 17 '22 17:10 SergeyKanzhelev

@mmiranda96: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 22 '22 06:10 k8s-ci-robot

@mmiranda96 do you plan to work on this? What's left?

SergeyKanzhelev avatar Dec 07 '22 18:12 SergeyKanzhelev

I did some additional investigation and it appears that most of the jobs that I tried to remove do not have a similar job that can replace them, mainly because existing similar jobs don't use containerd.

Job name Potential replacement Testgrid link Can replace?
ci-containerd-soak-cos-gce ci-kubernetes-soak-gce-gci https://testgrid.k8s.io/google-soak#gce-gci No, not using containerd
ci-cri-containerd-e2e-cos-gce-flaky ci-kubernetes-e2e-gci-gce-flaky https://testgrid.k8s.io/google-gce#gci-gce-flaky No, not using containerd
ci-cri-containerd-e2e-cos-gce ci-containerd-e2e-ubuntu-gce https://testgrid.k8s.io/sig-node-containerd#containerd-e2e-ubuntu Yes
ci-cri-containerd-e2e-cos-gce-ip-alias ci-kubernetes-e2e-gci-gce-ip-alias https://testgrid.k8s.io/sig-network-gce#gci-gce-ip-alias No, not using containerd
ci-cri-containerd-e2e-cos-gce-proto ci-kubernetes-e2e-gci-gce-proto https://testgrid.k8s.io/google-gce#gci-gce-proto No, not using containerd
ci-cri-containerd-e2e-cos-gce-reboot ci-kubernetes-e2e-gci-gce-reboot https://testgrid.k8s.io/google-gce#gce-cos-master-reboot No, not using containerd
ci-cri-containerd-e2e-cos-gce-serial ci-kubernetes-e2e-gci-gce-serial https://testgrid.k8s.io/google-gce#gce-cos-master-serial No, not using containerd
ci-cri-containerd-e2e-cos-gce-slow ci-kubernetes-e2e-gci-gce-slow https://testgrid.k8s.io/google-gce#gce-cos-master-slow No, not using containerd

I'm only deleting ci-cri-containerd-e2e-cos-gce, since it's the only one with a similar enough existing job.

mmiranda96 avatar Dec 13 '22 17:12 mmiranda96

/retest all

mmiranda96 avatar Dec 13 '22 17:12 mmiranda96

@mmiranda96: The /retest command does not accept any targets. The following commands are available to trigger required jobs:

  • /test pull-test-infra-gubernator
  • /test pull-test-infra-integration
  • /test pull-test-infra-prow-checkconfig
  • /test pull-test-infra-prow-image-build-test
  • /test pull-test-infra-unit-test
  • /test pull-test-infra-verify-lint

The following commands are available to trigger optional jobs:

  • /test pull-test-infra-bazel

Use /test all to run the following jobs that were automatically triggered:

  • pull-test-infra-gubernator
  • pull-test-infra-prow-checkconfig
  • pull-test-infra-unit-test
  • pull-test-infra-verify-lint

In response to this:

/retest all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Dec 13 '22 17:12 k8s-ci-robot

/retest

mmiranda96 avatar Dec 13 '22 17:12 mmiranda96

PTAL @SergeyKanzhelev

mmiranda96 avatar Dec 13 '22 18:12 mmiranda96

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mmiranda96, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Dec 14 '22 17:12 k8s-ci-robot

@mmiranda96: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key containerd.yaml using file config/jobs/kubernetes/sig-node/containerd.yaml

In response to this:

What does this PR do?

Delete job ci-cri-containerd-e2e-cos-gce (listed in https://github.com/kubernetes/kubernetes/issues/111876). This job is constantly failing, confirmed that not COS nor containerd monitor this Testgrid so we can delete them. Also, we have a similar job (ci-containerd-e2e-ubuntu-gce) running.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Dec 14 '22 18:12 k8s-ci-robot