test-infra icon indicating copy to clipboard operation
test-infra copied to clipboard

Gerrit controller for tide, implement provider interface for Gerrit

Open chaodaiG opened this issue 2 years ago • 2 comments

This PR implements the provider interface, but not hooked up yet. Intentionally left mergePRs method unimplemented as I would expect it to start with dry-run for a bit. Foreseeable remaining works:

  • Hook up inrepoconfig for Gerrit.
  • Parallelize query.
  • Figuring out how to report back to Gerrit. These will be addressed in following PRs.

/cc @cjwagner @mpherman2 @listx cc @alvaroaleman

chaodaiG avatar Aug 16 '22 16:08 chaodaiG

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaodaiG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 16 '22 16:08 k8s-ci-robot

Will add unit tests once get a first round of agreement on the approach from this PR

chaodaiG avatar Aug 16 '22 16:08 chaodaiG

Unit tests added, please review @cjwagner @mpherman2 @listx

chaodaiG avatar Aug 17 '22 23:08 chaodaiG

/lgtm

listx avatar Aug 19 '22 22:08 listx

Sorry this took so long. Pretty much all nits. Feel free to ignore. Thank you a lot! Please re-add lgtm

chaodaiG avatar Aug 19 '22 22:08 chaodaiG

/unhold

chaodaiG avatar Aug 19 '22 22:08 chaodaiG