test-infra
test-infra copied to clipboard
Gerrit controller for tide, implement provider interface for Gerrit
This PR implements the provider interface, but not hooked up yet. Intentionally left mergePRs
method unimplemented as I would expect it to start with dry-run for a bit. Foreseeable remaining works:
- Hook up inrepoconfig for Gerrit.
- Parallelize query.
- Figuring out how to report back to Gerrit. These will be addressed in following PRs.
/cc @cjwagner @mpherman2 @listx cc @alvaroaleman
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: chaodaiG
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~prow/OWNERS~~ [chaodaiG]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
Will add unit tests once get a first round of agreement on the approach from this PR
Unit tests added, please review @cjwagner @mpherman2 @listx
/lgtm
Sorry this took so long. Pretty much all nits. Feel free to ignore. Thank you a lot! Please re-add lgtm
/unhold