test-infra icon indicating copy to clipboard operation
test-infra copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes

Integration test fail when config update failed

Open chaodaiG opened this issue 2 years ago • 2 comments

Have encountered integration test kept going when there is a malformed config, the trailing ampersand feels like the reason why errors were swallowed

/cc @listx

chaodaiG avatar Aug 08 '22 15:08 chaodaiG

Rather than solving this by running everything serially, could we instead keep things parallel, but wait to check the exit codes once all the background processes have been started? IIUC we could follow these statements with a single wait $PID1 $PID2 ... command or a loop of wait -n commands and either option would capture the error.

done

chaodaiG avatar Aug 15 '22 15:08 chaodaiG

/retest

chaodaiG avatar Aug 18 '22 19:08 chaodaiG

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaodaiG, cjwagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 25 '22 01:08 k8s-ci-robot