test-infra
test-infra copied to clipboard
kubernetes
feat: add tekton v1beta1 support
This PR adds tekton v1beta1 support (side by side with v1alpha1).
This should come after https://github.com/kubernetes/test-infra/pull/27032
TODO:
- error handling
- unit tests
- docs
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
I think we still need an equivalent for run, right?
Not sure what you mean here. Isn’t Run used for custom tasks ?
@qaifshaikh: changing LGTM is restricted to collaborators
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: eddycharly, qaifshaikh
Once this PR has been reviewed and has the lgtm label, please assign mpherman2 for approval by writing /assign @mpherman2 in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Can we move forward with this @alvaroaleman ? Its not a breaking change anymore and makes it easy to upgrade to v1 when it becomes a standard!
Please note this PR needs a bit more work (docs, unit tests and better error handling). I will address missing bits soon, I’m currently on vacations.
Now https://github.com/kubernetes/test-infra/pull/27032 is in, I will try to terminate this one next week :crossed_fingers:
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: eddycharly, qaifshaikh
Once this PR has been reviewed and has the lgtm label, please assign cjwagner for approval by writing /assign @cjwagner in a comment. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@danilo-gemoli a couple unit tests are missing, I will add them by the end of the week (probably during the week-end).
would be nice to close this off before the year ends 😄 We'd be happy to help push this through if you want!
Since a few releases back in Tekton, the v1alpha1 support has been dropped totally. It would be great to see v1beta1 support (or even v1 support) in Prow.
Folks, I added the missing unit tests, please let me know how this looks. Sorry for the long delay.
cc @stevekuznetsov @alvaroaleman
@eddycharly: GitHub didn't allow me to request PR reviews from the following users: stevekuznetsov, alvaroaleman, chaodaiG.
Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.
In response to this:
/cc @stevekuznetsov @alvaroaleman @chaodaiG
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@eddycharly: GitHub didn't allow me to request PR reviews from the following users: stevekuznetsov, alvaroaleman, chaodaiG.
Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.
Not sure why this message 🤔