test-infra icon indicating copy to clipboard operation
test-infra copied to clipboard

[WIP] Add org/repo level pod timeout

Open ArkaSaha30 opened this issue 3 years ago • 5 comments

What type of PR is this? /kind feature

What this PR does / why we need it: Allow each team control their PodPendingTimeout, PodRunningTimeout, and PodUnscheduledTimeout at org/repo level. These values are configured globally, and might not be most optimal for all teams, adjusting the values of these fields often need to get approvals from lots of stakeholders when the prow instance has many tenants.

Which issue(s) this PR fixes: Refers to: https://github.com/kubernetes/test-infra/issues/26614

ArkaSaha30 avatar Jun 29 '22 16:06 ArkaSaha30

Welcome @ArkaSaha30!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Jun 29 '22 16:06 k8s-ci-robot

Hi @ArkaSaha30. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jun 29 '22 16:06 k8s-ci-robot

/assign @chaodaiG

ArkaSaha30 avatar Jun 29 '22 16:06 ArkaSaha30

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ArkaSaha30 Once this PR has been reviewed and has the lgtm label, please ask for approval from chaodaig by writing /assign @chaodaig in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 20 '22 13:09 k8s-ci-robot

@ArkaSaha30: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-test-infra-verify-lint 6ef7e04a5c168f56cbc2d41d5b12f6ccb03ebbfc link true /test pull-test-infra-verify-lint
pull-test-infra-integration 6ef7e04a5c168f56cbc2d41d5b12f6ccb03ebbfc link true /test pull-test-infra-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot avatar Oct 06 '22 07:10 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 04 '23 08:01 k8s-triage-robot

/close since the contributor will not move forward with this PR. https://github.com/kubernetes/test-infra/issues/26614#issuecomment-1369453877

amirrmonfared avatar Jan 06 '23 13:01 amirrmonfared

@amirrmonfared: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jan 06 '23 13:01 k8s-ci-robot