test-infra icon indicating copy to clipboard operation
test-infra copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes

Update the table of Prometheus metrics collected by Prow

Open chaodaiG opened this issue 2 years ago • 8 comments

What would you like to be added:

https://github.com/kubernetes/test-infra/tree/master/prow/metrics#prometheus-metrics contains the list of Prometheus metrics collected by Prow, which has something but there are many more not listed there.

Why is this needed:

Would be nice to provide a full list of metrics that we support so that it's easier to understanding monitoring.

The metrics sent to prometheus are defined with something like prometheus.NewGaugeVec( as pooledprs example, all other metrics are defined somewhat similar to this syntax, so should be relatively easy to find all.

/help /good-first-issue

chaodaiG avatar Jun 21 '22 14:06 chaodaiG

@chaodaiG: This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to this:

What would you like to be added:

https://github.com/kubernetes/test-infra/tree/master/prow/metrics#prometheus-metrics contains the list of Prometheus metrics collected by Prow, which has something but there are many more not listed there.

Why is this needed:

Would be nice to provide a full list of metrics that we support so that it's easier to understanding monitoring.

The metrics sent to prometheus are defined with something like prometheus.NewGaugeVec( as pooledprs example, all other metrics are defined somewhat similar to this syntax, so should be relatively easy to find all.

/help /good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jun 21 '22 14:06 k8s-ci-robot

/sig testing

chaodaiG avatar Jun 21 '22 14:06 chaodaiG

Hey @chaodaiG! 🙂 I am new to this repository and very excited to make my first contribution. Would you mind assigning this issue to me?

Ankit152 avatar Jun 22 '22 13:06 Ankit152

/assign ankit152

chaodaiG avatar Jun 22 '22 14:06 chaodaiG

Hey @chaodaiG 😄 I see there are promethues metrics present in the files under prow/bugzilla, prow/cier, prow/cmd/exporter, prow/cmd/sinker, prow/gerrit/adapter, prow/gerrit/client, prow/github, prow/githubserver, prow/jenkins, prow/jira, prow/kube, prow/plugins, prow/pubsub/subscriber, prow/version. Should I also add them as well? Just clarifying my doubt before I proceed. 🙂

Ankit152 avatar Jun 24 '22 14:06 Ankit152

Hey @chaodaiG 😄 I see there are promethues metrics present in the files under prow/bugzilla, prow/cier, prow/cmd/exporter, prow/cmd/sinker, prow/gerrit/adapter, prow/gerrit/client, prow/github, prow/githubserver, prow/jenkins, prow/jira, prow/kube, prow/plugins, prow/pubsub/subscriber, prow/version. Should I also add them as well? Just clarifying my doubt before I proceed. 🙂

yeah I think it would be good to include them all

chaodaiG avatar Jun 27 '22 17:06 chaodaiG

Added all of them! 🙂

Ankit152 avatar Jun 28 '22 18:06 Ankit152

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Sep 26 '22 19:09 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Oct 26 '22 19:10 k8s-triage-robot

This issue seems resolved by the PR https://github.com/kubernetes-sigs/prow/pull/12. You can check the rendered version at https://docs.prow.k8s.io/docs/metrics/.

jihoon-seo avatar Dec 01 '22 09:12 jihoon-seo

@amirrmonfared: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jan 03 '23 07:01 k8s-ci-robot