test-infra icon indicating copy to clipboard operation
test-infra copied to clipboard

Prow censor can mangle junit time attribute in rare circumstances

Open stbenjam opened this issue 3 years ago • 3 comments

What happened:

The prow censor found a sequence of integers it wanted to censor embedded in a junit testcase's time attribute, rendering it like this:

<testcase name="Find the input image root and tag it into the pipeline" time="0.0XXXXX687"/>

The XML is now unmarshallable:

time="2022-05-31T18:09:14.954Z" level=warning msg="failed to get junit test suites: error parsing content for jobrun strconv.ParseFloat: parsing \"0.0XXXXX687\": invalid syntax in file pr-logs/pull/openshift_installer/5951/pull-ci-openshift-installer-master-e2e-crc/1531677474260258816/artifacts/junit_operator.xml path pr-logs/pull/openshift_installer/5951/pull-ci-openshift-installer-master-e2e-crc/1531677474260258816"

What you expected to happen:

Leave it alone or at least leave it as a valid float.

How to reproduce it (as minimally and precisely as possible):

First time I've seen this happen, it's probably extremely rare.

Please provide links to example occurrences, if any:

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_installer/5951/pull-ci-openshift-installer-master-e2e-crc/1531677474260258816/artifacts/junit_operator.xml

Anything else we need to know?:

stbenjam avatar May 31 '22 18:05 stbenjam

/sig testing

stbenjam avatar May 31 '22 18:05 stbenjam

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 29 '22 18:08 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Sep 28 '22 18:09 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-triage-robot avatar Oct 28 '22 19:10 k8s-triage-robot

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 28 '22 19:10 k8s-ci-robot