test-infra icon indicating copy to clipboard operation
test-infra copied to clipboard

Allow setting custom CONTRIBUTING.md repo, branch and path in DCO plugin

Open zuc opened this issue 3 years ago • 9 comments

This allows the use of a custom CONTRIBUTING.md path to be linked in the DCO plugin PR message.

Signed-off-by: Michele Zuccala [email protected]

zuc avatar Mar 03 '22 20:03 zuc

CLA Signed

The committers are authorized under a signed CLA.

  • :white_check_mark: Michele Zuccala (99836d6f96bb6ac8c275de96c10ada1e6a1ccb3d)

Welcome @zuc!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Mar 03 '22 20:03 k8s-ci-robot

Hi @zuc. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 03 '22 20:03 k8s-ci-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov, zuc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Mar 03 '22 20:03 k8s-ci-robot

@zuc: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-test-infra-unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 03 '22 20:03 k8s-ci-robot

/ok-to-test

dims avatar Apr 14 '22 13:04 dims

@dims @stevekuznetsov any chance we can get this lgtm-ed/merged soon? 🙏

zuc avatar May 03 '22 10:05 zuc

/lgtm /hold

matthyx avatar May 04 '22 10:05 matthyx

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 02 '22 10:08 k8s-triage-robot

/remove-lifecycle stale

zuc avatar Aug 31 '22 10:08 zuc

/retest

zuc avatar Aug 31 '22 10:08 zuc

Hey @matthyx - do you think we can merge this?

zuc avatar Aug 31 '22 13:08 zuc

yes, sorry /unhold

matthyx avatar Aug 31 '22 19:08 matthyx