test-infra icon indicating copy to clipboard operation
test-infra copied to clipboard

Rename pull-kubernetes-e2e-gce-ubuntu-containerd to pull-kubernetes-e2e-gce

Open dims opened this issue 4 years ago • 17 comments

pull-kubernetes-e2e-gce-ubuntu-containerd has been the main CI job in presubmit that runs all the e2e tests for a while now. Historic note is that it replaced a job named pull-kubernetes-e2e-gce so we had added the qualifer that this was a ubuntu OS running containerd when we added this job. At this point since this is the default job, let's give it the shorter name.

Notes from @BenTheElder on slack:

  • Not sure if prow status reconciler can handle this. We may end up with wrong status(es) everywhere
  • In the past we did renames and prow handling them by updating the statuses on rename
  • We probably need to do it before test freeze, or early next cycle
  • Status Reconciler is here : https://github.com/kubernetes/test-infra/blob/ca06d20ff4c490bc07aefe05409e0741e76bd5e7/prow/cmd/status-reconciler/README.md
  • We also have the manual bulk migratestatus tool that @spiffxp or another github admin can run anyhow if we have to

dims avatar Mar 18 '21 12:03 dims

I'm wary of the same job name meaning two different things depending on what branch a PR targets. Do you intend to backport to older release branches?

spiffxp avatar Mar 27 '21 19:03 spiffxp

I'm wary of the same job name meaning two different things depending on what branch a PR targets. Do you intend to backport to older release branches?

Yes.

But I think we should not do this until around at least a week into 1.22 (after the queue drains post-release) to avoid disruption.

BenTheElder avatar Mar 27 '21 19:03 BenTheElder

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

fejta-bot avatar Jun 25 '21 19:06 fejta-bot

/remove-lifecycle stale we'll probably need to wait for next release cycle, we have to be careful about when we change up the list of blocking presubmit statuses, it's disruptive

BenTheElder avatar Jun 25 '21 19:06 BenTheElder

I suggest we do this after the next patch release and before the v1.23 release cycle starts

So based on

  • https://kubernetes.io/releases/patch-releases/ sometime after 2021-08-11
  • https://github.com/kubernetes/sig-release/blob/master/releases/release-1.23/README.md sometime before 2021-08-23

spiffxp avatar Jul 27 '21 03:07 spiffxp

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Oct 25 '21 03:10 k8s-triage-robot

/remove-lifecycle stale

looks like we missed the boat for 1.23, let's try before 1.24 starts

dims avatar Oct 25 '21 15:10 dims

/assign

dims avatar Oct 25 '21 15:10 dims

/milestone v1.24

spiffxp avatar Nov 24 '21 01:11 spiffxp

/priority important-longterm

spiffxp avatar Nov 24 '21 01:11 spiffxp

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Feb 22 '22 01:02 k8s-triage-robot

/remove-lifecycle stale

BenTheElder avatar Feb 22 '22 07:02 BenTheElder

@dims punt to 1.25?

BenTheElder avatar Apr 19 '22 02:04 BenTheElder

cc also @ehashman @SergeyKanzhelev (CRI-in-presubmit optics amongst other things ...)

BenTheElder avatar Apr 19 '22 02:04 BenTheElder

@BenTheElder yep let's do this as soon as 1.25 opens up!

dims avatar Apr 19 '22 02:04 dims

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jul 18 '22 03:07 k8s-triage-robot

Dang, i keep forgetting to do this!

dims avatar Jul 27 '22 00:07 dims

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Oct 25 '22 01:10 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Nov 24 '22 02:11 k8s-triage-robot

/remove-lifecycle rotten

ping @dims

ehashman avatar Nov 30 '22 23:11 ehashman

@ehashman i don't know if i have the strength :)

dims avatar Nov 30 '22 23:11 dims

found some :)

dims avatar Dec 05 '22 02:12 dims

/close

dims avatar Dec 09 '22 20:12 dims

/close

dims avatar Dec 09 '22 20:12 dims

@dims: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Dec 09 '22 20:12 k8s-ci-robot

@dims: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Dec 09 '22 20:12 k8s-ci-robot