release
release copied to clipboard
kubernetes
images: Use crane for pushing release images instead of docker
What type of PR is this?
What this PR does / why we need it:
Currently, we're loading the images into docker, retagging them, and then push them onto the registry.
This workflow is incompatible with Windows images, as docker load does not work for them, resulting in the following error:
cannot load windows image on linux
However, crane does not load the image, it just pushes it directly with the given tag. This will allow us to push any Windows image we might have (e.g.: Windows kube-proxy image).
Which issue(s) this PR fixes:
Related: https://github.com/kubernetes/kubernetes/pull/109939
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE
@claudiubelu: Adding label: do-not-merge/blocked-paths because PR changes a protected file.
Reasons for blocking this PR:
[Changes to push-build.sh will immediately affect the Kubernetes CI. This PR must be explicitly approved by SIG Release repo admins.]
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: claudiubelu Once this PR has been reviewed and has the lgtm label, please ask for approval from cpanato. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Any idea why the pull-release-cluster-up job is failing? The logs do not reveal much.
This job seems to have failed for a long time, let me create an issue for it.
Edit: https://github.com/kubernetes/release/issues/3588
This is going to allow us to publish Windows images similar to publishing Linux images
/kind feature /priority important-soon
This PR depended on https://github.com/kubernetes/kubernetes/pull/109939, which just merged. We can move ahead with this PR.
@claudiubelu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-release-cluster-up | d04801aa5b29517f2265bc2e8bf0afef3e071cfc | link | true | /test pull-release-cluster-up |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle rotten - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten