release icon indicating copy to clipboard operation
release copied to clipboard

krel can not handle backticks at the beginning of text field

Open ramrodo opened this issue 3 years ago • 9 comments

What happened:

At creating the draft PR for release notes for alpha.3 (or any other target release) with krel, it throws this error:

FATA creating Draft PR: while running release notes fix flow: while getting map for PR #113026:
while reading release notes maps: while parsing note map in
/var/folders/zs/4r38xsjd1lz17td037k933mw0000gp/T/k8s-2238154750/releases/release-1.26/release-notes/maps/pr-112386-map.yaml:
decoding note map: yaml: line 3: found character that cannot start any token

According to issues sig-release#2073 and sig-release#1974 this happens when there are backtips at the beginning of the value of text field.

What you expected to happen:

Parse/Handle correctly when krel find backticks at the beginning of text field

How to reproduce it (as minimally and precisely as possible):

  1. Have a release note map with backticks at the beginning under releases/release-1.26/release-notes/maps/ folder.
  2. Execute krel release-notes commands as follows:
krel release-notes --create-draft-pr --fork=<user> --fix --tag=v1.26.0-alpha.3 --list-v2
  1. See the error thrown

Anything else we need to know?:

Environment:

  • Cloud provider or hardware configuration: N/A
  • OS (e.g: cat /etc/os-release): Linux (Any flavor)
  • Kernel (e.g. uname -a): 5.14.21
  • Others:

ramrodo avatar Nov 09 '22 17:11 ramrodo

/assign

rjsadow avatar Jan 20 '23 20:01 rjsadow

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Apr 20 '23 20:04 k8s-triage-robot

/remove-lifecycle stale

ramrodo avatar Apr 27 '23 16:04 ramrodo

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 19 '24 11:01 k8s-triage-robot

/remove-lifecycle stale

xmudrii avatar Jan 19 '24 18:01 xmudrii

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Apr 18 '24 19:04 k8s-triage-robot

/remove-lifecycle stale

xmudrii avatar Apr 19 '24 08:04 xmudrii

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jul 18 '24 09:07 k8s-triage-robot

/remove-lifecycle stale

ramrodo avatar Jul 19 '24 20:07 ramrodo